Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 23983004: Web MIDI: implement right sysex handling for received messages. (Closed)

Created:
7 years, 3 months ago by Takashi Toyoshima
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Web MIDI: implement right sysex handling for received messages. I missed to apply ChildProcessSecurityPolicy to receive side. Blink needs additional sysex filter per MIDIAccess object. BUG=163795 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221662

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M content/browser/renderer_host/media/midi_host.cc View 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Takashi Toyoshima
Hi scherkus, I committed a sender side change to support child process security policy before. ...
7 years, 3 months ago (2013-09-05 09:44:21 UTC) #1
scherkus (not reviewing)
lgtm
7 years, 3 months ago (2013-09-05 19:03:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/23983004/1
7 years, 3 months ago (2013-09-06 03:40:38 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 09:14:21 UTC) #4
Message was sent while issue was closed.
Change committed as 221662

Powered by Google App Engine
This is Rietveld 408576698