Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 23983003: DevTools: Remove Network.requestServedFromMemoryCache event from protocol. (Closed)

Created:
7 years, 3 months ago by vsevik
Modified:
7 years, 3 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Remove Network.requestServedFromMemoryCache event from protocol. BUG=160404 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157306

Patch Set 1 #

Patch Set 2 : Dirty hack: removed event from published protocol version. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -57 lines) Patch
M Source/devtools/Inspector-1.0.json View 1 1 chunk +0 lines, -13 lines 0 comments Download
M Source/devtools/front_end/NetworkManager.js View 2 chunks +0 lines, -31 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vsevik
Please review
7 years, 3 months ago (2013-09-05 07:45:09 UTC) #1
pfeldman
lgtm
7 years, 3 months ago (2013-09-05 11:42:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/23983003/1
7 years, 3 months ago (2013-09-05 11:42:43 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-05 12:00:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/23983003/1003
7 years, 3 months ago (2013-09-05 12:28:26 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 14:13:30 UTC) #6
Message was sent while issue was closed.
Change committed as 157306

Powered by Google App Engine
This is Rietveld 408576698