Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 23981002: Provide configurable closing of web contents modal dialogs on interstitial webui (Closed)

Created:
7 years, 3 months ago by Mike Wittman
Modified:
7 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Provide configurable closing of web contents modal dialogs on interstitial webui Allow individual web contents modal dialog users to specify that dialogs should be closed when encountering interstitial webui (e.g. due to SSL warnings). Future CLs will enable use of this functionality for most dialogs. BUG=240575 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221575

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase + add test comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -11 lines) Patch
M components/web_modal/web_contents_modal_dialog_manager.h View 4 chunks +18 lines, -1 line 0 comments Download
M components/web_modal/web_contents_modal_dialog_manager.cc View 9 chunks +45 lines, -10 lines 0 comments Download
M components/web_modal/web_contents_modal_dialog_manager_unittest.cc View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mike Wittman
Hi Scott, can you do a committer review? This CL depends on https://codereview.chromium.org/23475022 for its ...
7 years, 3 months ago (2013-09-05 01:36:28 UTC) #1
sky
LGTM https://codereview.chromium.org/23981002/diff/1/components/web_modal/web_contents_modal_dialog_manager_unittest.cc File components/web_modal/web_contents_modal_dialog_manager_unittest.cc (right): https://codereview.chromium.org/23981002/diff/1/components/web_modal/web_contents_modal_dialog_manager_unittest.cc#newcode235 components/web_modal/web_contents_modal_dialog_manager_unittest.cc:235: TEST_F(WebContentsModalDialogManagerTest, InterstitialWebUI) { Add description.
7 years, 3 months ago (2013-09-05 16:19:19 UTC) #2
Mike Wittman
https://codereview.chromium.org/23981002/diff/1/components/web_modal/web_contents_modal_dialog_manager_unittest.cc File components/web_modal/web_contents_modal_dialog_manager_unittest.cc (right): https://codereview.chromium.org/23981002/diff/1/components/web_modal/web_contents_modal_dialog_manager_unittest.cc#newcode235 components/web_modal/web_contents_modal_dialog_manager_unittest.cc:235: TEST_F(WebContentsModalDialogManagerTest, InterstitialWebUI) { On 2013/09/05 16:19:19, sky wrote: > ...
7 years, 3 months ago (2013-09-05 20:22:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wittman@chromium.org/23981002/6001
7 years, 3 months ago (2013-09-05 23:26:33 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 05:18:01 UTC) #5
Message was sent while issue was closed.
Change committed as 221575

Powered by Google App Engine
This is Rietveld 408576698