Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1314)

Unified Diff: chrome/browser/extensions/activity_log/counting_policy.h

Issue 23980002: Activity Log: allow searching by day (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed error from last rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/counting_policy.h
diff --git a/chrome/browser/extensions/activity_log/counting_policy.h b/chrome/browser/extensions/activity_log/counting_policy.h
index ec8a2e508bbfbfd30bf4b9aad2547f4bbe914149..a3c9d9d6130975eb58904df9219361ca0b7395f5 100644
--- a/chrome/browser/extensions/activity_log/counting_policy.h
+++ b/chrome/browser/extensions/activity_log/counting_policy.h
@@ -22,18 +22,13 @@ class CountingPolicy : public ActivityLogDatabasePolicy {
virtual void ProcessAction(scoped_refptr<Action> action) OVERRIDE;
- virtual void ReadData(
- const std::string& extension_id,
- const int day,
- const base::Callback
- <void(scoped_ptr<Action::ActionVector>)>& callback) OVERRIDE;
-
virtual void ReadFilteredData(
const std::string& extension_id,
const Action::ActionType type,
const std::string& api_name,
const std::string& page_url,
const std::string& arg_url,
+ const int days_ago,
const base::Callback
<void(scoped_ptr<Action::ActionVector>)>& callback) OVERRIDE;
@@ -77,18 +72,13 @@ class CountingPolicy : public ActivityLogDatabasePolicy {
// Internal method to read data from the database; called on the database
// thread.
- scoped_ptr<Action::ActionVector> DoReadData(
- const std::string& extension_id,
- const int days_ago);
-
- // Internal method to read data from the database; called on the database
- // thread.
scoped_ptr<Action::ActionVector> DoReadFilteredData(
const std::string& extension_id,
const Action::ActionType type,
const std::string& api_name,
const std::string& page_url,
- const std::string& arg_url);
+ const std::string& arg_url,
+ const int days_ago);
// The implementation of RemoveURLs; this must only run on the database
// thread.

Powered by Google App Engine
This is Rietveld 408576698