DevTools: ConsoleViewMessage rewrite signatures for formatter functions

DevTools: ConsoleViewMessage rewrite signatures for formatter functions

Object type formatters now return an element instead of taking one as an
argument. Function signatures are also updated with the necessary dependencies
to isolate them from the rest of ConsoleViewMessage.

DO NOT COMMIT

This CL has been split up:
- https://codereview.chromium.org/2454923003/
- https://codereview.chromium.org/2449973005/

[luoe, 2016-10-07 21:59:54]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 22:00:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[luoe, 2016-10-07 22:16:19]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[luoe, 2016-10-07 22:16:19]

ptal

[lushnikov, 2016-10-07 22:29:14]

let's not land this for now - it doesn't give much benefit

[commit-bot: I haz the power, 2016-10-07 23:50:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 23:50:40]

Dry run: This issue passed the CQ dry run.

[luoe, 2016-10-10 21:47:31]

Description was changed from

==========
DevTools: ConsoleViewMessage rename obj, elem >> object, elements
==========

to

==========
DevTools: ConsoleViewMessage rewrite signatures for formatter functions

Object type formatters now return an element instead of taking one as an
argument. Function signatures are also updated with the necessary dependencies
to isolate them from the rest of ConsoleViewMessage.
==========

[luoe, 2016-10-10 21:49:59]

Description was changed from

==========
DevTools: ConsoleViewMessage rewrite signatures for formatter functions

Object type formatters now return an element instead of taking one as an
argument. Function signatures are also updated with the necessary dependencies
to isolate them from the rest of ConsoleViewMessage.
==========

to

==========
DevTools: ConsoleViewMessage rewrite signatures for formatter functions

Object type formatters now return an element instead of taking one as an
argument. Function signatures are also updated with the necessary dependencies
to isolate them from the rest of ConsoleViewMessage.
==========

[luoe, 2016-10-10 21:50:37]

CL updated.  No more renaming obj >> object.  This should take into account
comments from https://codereview.chromium.org/2383293002/

[lushnikov, 2016-10-12 20:58:23]

https://codereview.chromium.org/2397933005/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
(left):

https://codereview.chromium.org/2397933005/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:706:
elem.classList.remove("object-value-string");
let's address this separately by moving "object-value-.." css classes down to
the appropriate builders. (this class should not be set in the _format method!)

https://codereview.chromium.org/2397933005/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
(right):

https://codereview.chromium.org/2397933005/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:459:
_formatParameter: function(consoleMessage, linkifier, output, forceObjectFormat,
includePreview)
let's pass consoleMessageType only

https://codereview.chromium.org/2397933005/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:472:
element = this._formatParameterAsError(output, linkifier,
consoleMessage.target());
you can get target from remoteobject

https://codereview.chromium.org/2397933005/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:754:
var span = element.createChild("span", "object-value-error source-code");
object-value-error is not used at all?

https://codereview.chromium.org/2397933005/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:821:
_formatWithSubstitutionString: function(consoleMessage, linkifier, format,
parameters, formattedResult)
you won't need console message here - just consoleMessageType would be enough

[luoe, 2016-10-13 20:44:21]

Patches 6+7
- moving classname defs into each builder
- remove unnecessary classes for typedarray, promise, symbol, error

Patch 8
- other comments addressed (messageType, object.target())

Can you please take a look by diffing w/ patch 5?

https://codereview.chromium.org/2397933005/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
(left):

https://codereview.chromium.org/2397933005/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:706:
elem.classList.remove("object-value-string");
On 2016/10/12 20:58:23, lushnikov wrote:
> let's address this separately by moving "object-value-.." css classes down to
> the appropriate builders. (this class should not be set in the _format
method!)

Done in patch set 6+7.  Changes can be seen by diffing with set 5.

https://codereview.chromium.org/2397933005/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
(right):

https://codereview.chromium.org/2397933005/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:459:
_formatParameter: function(consoleMessage, linkifier, output, forceObjectFormat,
includePreview)
On 2016/10/12 20:58:23, lushnikov wrote:
> let's pass consoleMessageType only

Done.

https://codereview.chromium.org/2397933005/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:472:
element = this._formatParameterAsError(output, linkifier,
consoleMessage.target());
On 2016/10/12 20:58:23, lushnikov wrote:
> you can get target from remoteobject

Done.

https://codereview.chromium.org/2397933005/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:754:
var span = element.createChild("span", "object-value-error source-code");
On 2016/10/12 20:58:23, lushnikov wrote:
> object-value-error is not used at all?

Done.

https://codereview.chromium.org/2397933005/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:821:
_formatWithSubstitutionString: function(consoleMessage, linkifier, format,
parameters, formattedResult)
On 2016/10/12 20:58:23, lushnikov wrote:
> you won't need console message here - just consoleMessageType would be enough

Done.

[lushnikov, 2016-10-14 00:20:40]

let's make patchst #6 as a separate CL

[luoe, 2016-10-14 18:48:22]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 18:49:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[luoe, 2016-10-14 18:49:17]

On 2016/10/14 00:20:40, lushnikov wrote:
> let's make patchst #6 as a separate CL

Patches 6+7 are in another CL: https://codereview.chromium.org/2424443003

[commit-bot: I haz the power, 2016-10-14 20:26:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 20:26:35]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-10-18 23:07:40]

https://chromiumcodereview.appspot.com/2397933005/diff/160001/third_party/Web...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
(left):

https://chromiumcodereview.appspot.com/2397933005/diff/160001/third_party/Web...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:706:
elem.classList.remove("object-value-string");
this is non-trivial change in this mostly mechanical CL. Let's extract
non-trivial change and do it separately. Most likely, you would not need the
object-value-string-inner class, which you introduce in this CL!

[luoe, 2016-10-20 23:01:57]

https://codereview.chromium.org/2397933005/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
(left):

https://codereview.chromium.org/2397933005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:706:
elem.classList.remove("object-value-string");
This "object-value-string-inner" change should* be the only class-related change
in this CL.

The other CL was split out, but unfortunately it is not feasible to move class
defs into builders right now without breaking other places that depend on
object-value-type.

[lushnikov, 2016-10-22 03:10:19]

https://codereview.chromium.org/2397933005/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
(right):

https://codereview.chromium.org/2397933005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:138:
table = this._parameterToRemoteObject(table, this._target());
consoleMessage.target();

https://codereview.chromium.org/2397933005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:287:
anchorElement = this._linkifyScriptId(linkifier, consoleMessage);
1. the order should be consistent
2. can we pass just scriptId?

can we inline linkifyScriptId right away?

https://codereview.chromium.org/2397933005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:289:
anchorElement = this._linkifyStackTraceTopFrame(linkifier, consoleMessage);
inline this as well

https://codereview.chromium.org/2397933005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:291:
anchorElement = this._linkifyLocation(linkifier, consoleMessage);
inline this as well

https://codereview.chromium.org/2397933005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:358:
_linkifyLocation: function(linkifier, consoleMessage)
will be removed

https://codereview.chromium.org/2397933005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:363:
return this._linkifier.linkifyScriptLocation(target, null, consoleMessage.url ||
"", consoleMessage.line, consoleMessage.column, "console-message-url");
linkifier

https://codereview.chromium.org/2397933005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:370:
*/
will be removed

https://codereview.chromium.org/2397933005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:384:
_linkifyScriptId: function(linkifier, consoleMessage)
will be removed

https://codereview.chromium.org/2397933005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:485:
element = this._formatParameterAsObject(output, linkifier, includePreview);
element= createElement("span");
element.appendChild(this._formatParameterAsObject(output, linkifier,
includePreview));

https://codereview.chromium.org/2397933005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:529:
_formatParameterAsObject: function(obj, linkifier, includePreview)
let's not split this into two - we don't need more functions!

https://codereview.chromium.org/2397933005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:655:
_formatParameterAsArray: function(array, linkifier, messageType)
let's pass linkifier as the last argument -- everywhere?

https://codereview.chromium.org/2397933005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:657:
var element = createElement("span");
var result = .. -- everywhere

https://codereview.chromium.org/2397933005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:703:
var entryElement = elements[i];
discard this

https://codereview.chromium.org/2397933005/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:816:
* @param {!WebInspector.Linkifier} linkifier
make it last -- everywhere

[luoe, 2016-10-27 19:43:59]

Description was changed from

==========
DevTools: ConsoleViewMessage rewrite signatures for formatter functions

Object type formatters now return an element instead of taking one as an
argument. Function signatures are also updated with the necessary dependencies
to isolate them from the rest of ConsoleViewMessage.
==========

to

==========
DevTools: ConsoleViewMessage rewrite signatures for formatter functions

Object type formatters now return an element instead of taking one as an
argument. Function signatures are also updated with the necessary dependencies
to isolate them from the rest of ConsoleViewMessage.

DO NOT COMMIT

This CL has been split up:
- https://codereview.chromium.org/2454923003/
- https://codereview.chromium.org/2449973005/
==========