android_webview/java/src/org/chromium/android_webview/AwContentsClient.java - Issue 239793002: Handle media access permission request

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

Issue 239793002: Handle media access permission request (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix error, landed it again Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContents.java ('k') | android_webview/java/src/org/chromium/android_webview/permission/AwPermissionRequest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

index fa59347f18dd2c8e5076bd37c4b57a8e928244fd..e5ce0273e995ae5e8bd6ed314a7e9244391d89fa 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

@@ -17,6 +17,7 @@ import android.webkit.GeolocationPermissions;

import android.webkit.ValueCallback;

import android.webkit.WebChromeClient;

+import org.chromium.android_webview.permission.AwPermissionRequest;

import org.chromium.content.browser.ContentViewCore;

import org.chromium.content.browser.WebContentsObserverAndroid;

import org.chromium.net.NetError;

@@ -189,6 +190,13 @@ public abstract class AwContentsClient {

public abstract void onGeolocationPermissionsHidePrompt();

+ // TODO(michaelbai): Change the abstract once merged

+ public /*abstract*/ void onPermissionRequest(AwPermissionRequest awPermissionRequest) {}

+ // TODO(michaelbai): Change the abstract once merged

+ public /*abstract*/ void onPermissionRequestCanceled(

+ AwPermissionRequest awPermissionRequest) {}

public abstract void onScaleChangedScaled(float oldScale, float newScale);

protected abstract void handleJsAlert(String url, String message, JsResultReceiver receiver);