cc/layers/layer_impl.cc - Issue 23978008: Suppress scrollbar animation if the scroll gesture does not scroll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/layer_impl.cc

Issue 23978008: Suppress scrollbar animation if the scroll gesture does not scroll (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix LayerTreeHostImpl unit tests Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « cc/animation/scrollbar_animation_controller_linear_fade_unittest.cc ('k') | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/layers/layer_impl.cc

diff --git a/cc/layers/layer_impl.cc b/cc/layers/layer_impl.cc

index aee85cf9deeeebca3bdcb153fdeccd1e464f6038..615fcf2c5c0ef0528a6cc6f448dc4fa066dbb021 100644

--- a/cc/layers/layer_impl.cc

+++ b/cc/layers/layer_impl.cc

@@ -975,9 +975,8 @@ void LayerImpl::UpdateScrollbarPositions() {

return;

last_scroll_offset_ = current_offset;

- if (scrollbar_animation_controller_ &&

- !scrollbar_animation_controller_->IsScrollGestureInProgress()) {

- scrollbar_animation_controller_->DidProgrammaticallyUpdateScroll(

+ if (scrollbar_animation_controller_) {

+ scrollbar_animation_controller_->DidScrollUpdate(

layer_tree_impl_->CurrentPhysicalTimeTicks());

}

« no previous file with comments | « cc/animation/scrollbar_animation_controller_linear_fade_unittest.cc ('k') | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »