Issue 23978007: Identity API: prevent install time OAuth prompts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23978007: Identity API: prevent install time OAuth prompts (Closed)

Created:
7 years, 3 months ago by Michael Courage

Modified:
7 years, 3 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Identity API: prevent install time OAuth prompts This change removes the code to conditionally fetch scope information, which sometimes would sometimes display the scopes at the wrong time. ExtensionInstallPrompt never needs to fetch or approve OAuth scopes itself. The Identity API passes in a list when necessary, and also takes care of all grants. BUG=277117 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221661

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -40 lines)			Patch
	M	chrome/browser/extensions/extension_install_prompt.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	chrome/browser/extensions/extension_install_prompt.cc	View		5 chunks	+4 lines, -37 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/courage@chromium.org/23978007/1

7 years, 3 months ago (2013-09-05 18:49:22 UTC) #3

Message was sent while issue was closed.

Change committed as 221661

Expand Messages | Collapse Messages