EME: Check capabilities provided only on success

third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp

Index: third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp
diff --git a/third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp b/third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp
index cccf1ca57a574753f64316221f16d1ea56b09ac4..8dbbaab2c612b043bf9e04f3e46b5a777bfb1ac2 100644
--- a/third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp
+++ b/third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp
@@ -129,7 +129,7 @@ class MediaKeySystemAccessInitializer final : public EncryptedMediaRequest {
   // See http://crbug.com/605661.
   void checkEmptyCodecs(const WebMediaKeySystemConfiguration&);
 
-  // Log UseCounter if configuration does not have at least one of
+  // Log UseCounter if selected configuration does not have at least one of
   // 'audioCapabilities' and 'videoCapabilities' non-empty.
   // TODO(jrummell): Switch to deprecation message once we have data.
   // See http://crbug.com/616233.
@@ -162,8 +162,6 @@ MediaKeySystemAccessInitializer::MediaKeySystemAccessInitializer(
     webConfig.videoCapabilities =
         convertCapabilities(config.videoCapabilities());
 
-    checkCapabilitiesProvided(webConfig);
-
     DCHECK(config.hasDistinctiveIdentifier());
     webConfig.distinctiveIdentifier =
         convertMediaKeysRequirement(config.distinctiveIdentifier());
@@ -196,6 +194,7 @@ MediaKeySystemAccessInitializer::MediaKeySystemAccessInitializer(
 void MediaKeySystemAccessInitializer::requestSucceeded(
     WebContentDecryptionModuleAccess* access) {
   checkEmptyCodecs(access->getConfiguration());
+  checkCapabilitiesProvided(access->getConfiguration());
 
   m_resolver->resolve(
       new MediaKeySystemAccess(m_keySystem, wrapUnique(access)));
@@ -284,6 +283,9 @@ void MediaKeySystemAccessInitializer::checkEmptyCodecs(
 
 void MediaKeySystemAccessInitializer::checkCapabilitiesProvided(

[xhwang, 2016/10/06 17:01:05]

"provided" is a bit ambiguous..

[jrummell, 2016/10/06 18:43:04]

Removed "Provided".

     const WebMediaKeySystemConfiguration& config) {
+  // This is only checking that at least one capability is provided in the
+  // selected configuration, as apps may pass empty capabilities for
+  // compatibility with other implementations.
   bool atLeastOneAudioCapability = config.audioCapabilities.size() > 0;
   bool atLeastOneVideoCapability = config.videoCapabilities.size() > 0;