Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 23971004: Account for the case when there are no resource timings (Closed)

Created:
7 years, 3 months ago by qyearsley
Modified:
7 years, 3 months ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Visibility:
Public.

Description

Account for the case when there are no resource timings BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221502

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools/perf/metrics/speedindex.js View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
qyearsley
[Small fix] (Paul noticed a bug in the timeSinceLastResponseAfterLoadMs function in speedindex.js: If there are ...
7 years, 3 months ago (2013-09-04 22:52:22 UTC) #1
tonyg
lgtm
7 years, 3 months ago (2013-09-04 22:58:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qyearsley@chromium.org/23971004/1
7 years, 3 months ago (2013-09-04 23:02:41 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-04 23:24:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qyearsley@chromium.org/23971004/1
7 years, 3 months ago (2013-09-05 16:55:16 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 20:16:06 UTC) #6
Message was sent while issue was closed.
Change committed as 221502

Powered by Google App Engine
This is Rietveld 408576698