Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 23969007: Fix threading races on WebAudioSourceProviderImpl::provideInput (Closed)

Created:
7 years, 3 months ago by haraken
Modified:
7 years, 3 months ago
CC:
blink-reviews, nessy, eae+blinkwatch, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Fix threading races on WebAudioSourceProviderImpl::provideInput Fix threading races on WebAudioSourceProviderImpl::provideInput According to the crash report (https://cluster-fuzz.appspot.com/testcase?key=4697390229487616), there is a threading race. Specifically, WebAudioSourceProviderImpl can be destructed by the main thread while WebAudioSourceProviderImpl::Stop() is being called by the audio thread. The core problem is that we're not calling WebAudioSourceProviderImpl::setClient(NULL) when HTMLMediaElement clears the audio source provider. BUG=284786 No tests because the crash depends on threading races and thus not reproducible. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157259

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M Source/core/html/HTMLMediaElement.cpp View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
haraken
This is already reviewed in https://chromiumcodereview.appspot.com/23691033/ dale, kbr: would you rubberstamp?
7 years, 3 months ago (2013-09-04 23:15:01 UTC) #1
Ken Russell (switch to Gerrit)
lgtm
7 years, 3 months ago (2013-09-04 23:23:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/23969007/1
7 years, 3 months ago (2013-09-04 23:26:21 UTC) #3
DaleCurtis
lgtm
7 years, 3 months ago (2013-09-05 00:14:47 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 02:07:01 UTC) #5
Message was sent while issue was closed.
Change committed as 157259

Powered by Google App Engine
This is Rietveld 408576698