Remove self as delegate when cleaning up AppLaunchController.

Remove self as delegate when cleaning up AppLaunchController.

The lifetime of the login webui can exceed that of the AppLaunchController,
so we need to do proper cleanup.

BUG=286406
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221880

[Tim Song, 2013-09-06 22:53:11]

PTAL. I couldn't replicate the bug, but I suspect that bad cleanup is the reason
for the crash. The login window widget and all the webui stuff seems to outlive
the LoginDisplayHost.

[xiyuan, 2013-09-06 23:06:48]

Widget::Close is async in aura. Think your suspicion is correct that login webui
outlives display host while the close is still in-fly.

https://codereview.chromium.org/23967008/diff/1/chrome/browser/chromeos/login...
File chrome/browser/chromeos/login/app_launch_controller.cc (right):

https://codereview.chromium.org/23967008/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/app_launch_controller.cc:126:
app_launch_splash_screen_actor_->SetDelegate(NULL);
Should we do this in the destructor rather than here?

[Tim Song, 2013-09-06 23:39:43]

https://codereview.chromium.org/23967008/diff/1/chrome/browser/chromeos/login...
File chrome/browser/chromeos/login/app_launch_controller.cc (right):

https://codereview.chromium.org/23967008/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/app_launch_controller.cc:126:
app_launch_splash_screen_actor_->SetDelegate(NULL);
On 2013/09/06 23:06:48, xiyuan wrote:
> Should we do this in the destructor rather than here?

Done.

[xiyuan, 2013-09-07 00:24:16]

lgtm

[commit-bot: I haz the power, 2013-09-07 01:30:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tengs@chromium.org/23967008/6001

[commit-bot: I haz the power, 2013-09-07 04:08:33]

Change committed as 221880