Reuse webview classic cookies file

Use webview classic cookies file to create the chromium based
webview's cookies file, for the first instance of the app, so
cookies are not lost.

BUG=b/9962984

TBRing safebrowsing_service and profile_impl_io_data changes since these are mechanical in nature.

TBR=mattm@chromium.org,mmenke@chromiumorg

adding no try since we have comments that are longer than 80 chars, and since this is allowed under style guidance.
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223400

[sgurun-gerrit only, 2013-09-14 18:56:43]

PTAL, thanks,

[joth, 2013-09-14 19:40:24]

nice

https://codereview.chromium.org/23964011/diff/3001/android_webview/browser/aw...
File android_webview/browser/aw_browser_context.cc (right):

https://codereview.chromium.org/23964011/diff/3001/android_webview/browser/aw...
android_webview/browser/aw_browser_context.cc:74: void
RecycleWebviewClassicCookieStore(const FilePath& cookie_store_path) {
nit: ImportLegacyCookieStore or MaybeMigrateLegacyCookieStore

https://codereview.chromium.org/23964011/diff/3001/android_webview/browser/aw...
android_webview/browser/aw_browser_context.cc:82: //
Source/WebKit/android/WebCoreSupport/WebCookieJar.cpp)
https://android.googlesource.com/platform/external/webkit/+/7151ed0c74599/Sou...

https://codereview.chromium.org/23964011/diff/3001/android_webview/browser/aw...
android_webview/browser/aw_browser_context.cc:146:
BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO),
don't pass this param. AIUI this is an internal detail the caller doesn't need
to know about

https://codereview.chromium.org/23964011/diff/3001/chrome/browser/profiles/pr...
File chrome/browser/profiles/profile_impl_io_data.cc (right):

https://codereview.chromium.org/23964011/diff/3001/chrome/browser/profiles/pr...
chrome/browser/profiles/profile_impl_io_data.cc:393:
BrowserThread::GetBlockingPool()->GetSequenceToken()));
could pass NULL for the second param and document an internal default will then
be used. /shrug

https://codereview.chromium.org/23964011/diff/3001/chrome/browser/profiles/pr...
chrome/browser/profiles/profile_impl_io_data.cc:491:
BrowserThread::GetBlockingPool()->GetSequenceToken()));
yeah... seems nicer as this is duplicated several times in here

[sgurun-gerrit only, 2013-09-14 20:45:01]

https://codereview.chromium.org/23964011/diff/3001/android_webview/browser/aw...
File android_webview/browser/aw_browser_context.cc (right):

https://codereview.chromium.org/23964011/diff/3001/android_webview/browser/aw...
android_webview/browser/aw_browser_context.cc:74: void
RecycleWebviewClassicCookieStore(const FilePath& cookie_store_path) {
On 2013/09/14 19:40:24, joth wrote:
> nit: ImportLegacyCookieStore or MaybeMigrateLegacyCookieStore

Done.

https://codereview.chromium.org/23964011/diff/3001/android_webview/browser/aw...
android_webview/browser/aw_browser_context.cc:82: //
Source/WebKit/android/WebCoreSupport/WebCookieJar.cpp)
On 2013/09/14 19:40:24, joth wrote:
>
https://android.googlesource.com/platform/external/webkit/+/7151ed0c74599/Sou...

Done.

https://codereview.chromium.org/23964011/diff/3001/android_webview/browser/aw...
android_webview/browser/aw_browser_context.cc:146:
BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO),
On 2013/09/14 19:40:24, joth wrote:
> don't pass this param. AIUI this is an internal detail the caller doesn't need
> to know about

Done.

https://codereview.chromium.org/23964011/diff/3001/chrome/browser/profiles/pr...
File chrome/browser/profiles/profile_impl_io_data.cc (right):

https://codereview.chromium.org/23964011/diff/3001/chrome/browser/profiles/pr...
chrome/browser/profiles/profile_impl_io_data.cc:393:
BrowserThread::GetBlockingPool()->GetSequenceToken()));
On 2013/09/14 19:40:24, joth wrote:
> could pass NULL for the second param and document an internal default will
then
> be used. /shrug

Done.

https://codereview.chromium.org/23964011/diff/3001/chrome/browser/profiles/pr...
chrome/browser/profiles/profile_impl_io_data.cc:491:
BrowserThread::GetBlockingPool()->GetSequenceToken()));
On 2013/09/14 19:40:24, joth wrote:
> yeah... seems nicer as this is duplicated several times in here

Done.

[joth, 2013-09-14 21:17:25]

lgtm

[sgurun-gerrit only, 2013-09-14 21:44:20]

joi: need lgtm for content/public/browser
erikwright: need lgtm for content/browser/net

[Jói, 2013-09-16 08:42:51]

//content/public LGTM.

[erikwright (departed), 2013-09-16 14:02:41]

content/browser/net LGTM.

[commit-bot: I haz the power, 2013-09-16 19:07:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sgurun@chromium.org/23964011/30001

[commit-bot: I haz the power, 2013-09-16 19:26:07]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[joth, 2013-09-16 19:36:50]

On 2013/09/16 19:26:07, I haz the power (commit-bot) wrote:
> Retried try job too often on chromium_presubmit for step(s) presubmit
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

It doesn't like the "overlength" comments that contain URLs. This is totally
allowed under the style guide so can NOTRY=true it I suppose.

[commit-bot: I haz the power, 2013-09-16 20:31:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sgurun@chromium.org/23964011/30001

[commit-bot: I haz the power, 2013-09-16 20:35:38]

Change committed as 223400

[mattm, 2013-09-24 02:14:09]

+mmenke also.
I just happened to see this, the TBRs weren't added to the reviewers.

safe_browsing lgtm.

[sgurun-gerrit only, 2013-09-24 02:18:51]

On 2013/09/24 02:14:09, mattm wrote:
> +mmenke also.
> I just happened to see this, the TBRs weren't added to the reviewers.
> 
> safe_browsing lgtm.

my mistake. sorry about that.