Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 23963003: Adding page names to all endure pagesets (Closed)

Created:
7 years, 3 months ago by edmundyan
Modified:
7 years, 3 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Visibility:
Public.

Description

Adding page names to all endure pagesets BUG=284547 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222241

Patch Set 1 #

Patch Set 2 : Using underscores for page names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M tools/perf/measurements/endure.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/perf/page_sets/calendar_forward_backward.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/gmail_alt_threadlist_conversation.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/gmail_alt_two_labels.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/gmail_expand_collapse_conversation.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/plus_alt_posts_photos.json View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
edmundyan
+machenbach: This change will break the current endure bots. We'll need to update the GraphingEndureLogProcessor ...
7 years, 3 months ago (2013-09-05 00:50:51 UTC) #1
tonyg
lgtm > Dave/Tony, did you want to add human-readable names to other pages in this ...
7 years, 3 months ago (2013-09-05 01:16:03 UTC) #2
Michael Achenbach
On 2013/09/05 01:16:03, tonyg wrote: > lgtm > > > Dave/Tony, did you want to ...
7 years, 3 months ago (2013-09-05 11:40:38 UTC) #3
edmundyan
On 2013/09/05 11:40:38, machenbach wrote: > Are you sure about the camel case style of ...
7 years, 3 months ago (2013-09-05 19:02:06 UTC) #4
dtu
lgtm
7 years, 3 months ago (2013-09-05 20:27:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/edmundyan@chromium.org/23963003/6001
7 years, 3 months ago (2013-09-10 00:06:58 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 09:23:19 UTC) #7
Message was sent while issue was closed.
Change committed as 222241

Powered by Google App Engine
This is Rietveld 408576698