[inspector] move changeBreakpointState from debugger-script to native

[inspector] move changeBreakpointState from debugger-script to native

* introduced v8::DebugInterface::ChangeBreakOnException(Isolate*,ExceptionBreakState);
* migrated inspector to new API;
* added cctest for new API;
* added inspector test for setPauseOnExceptionState.

BUG=chromium:652939, v8:5510
R=dgozman@chromium.org,yangguo@chromium.org

Committed: https://crrev.com/377533fc06cb43e84a765775ebf057c053961973
Cr-Commit-Position: refs/heads/master@{#40413}

[kozy, 2016-10-06 20:33:18]

Patchset #1 (id:1) has been deleted

[kozy, 2016-10-06 20:33:34]

Please take a look!

[dgozman, 2016-10-06 21:48:43]

https://codereview.chromium.org/2396193002/diff/20001/include/v8-debug.h
File include/v8-debug.h (right):

https://codereview.chromium.org/2396193002/diff/20001/include/v8-debug.h#newc...
include/v8-debug.h:291: static void ChangeBreakOnException(Isolate* isolate,
I wonder whether we want new public C++ api for debugging. This patch moves api
from js to native, which is good in some way, but maybe we just want
"v8-inspector-only" api to avoid growing v8::Debug and leave wired protocol as
"the api" ?

Yang, what's your view on this? Should we discuss pros and cons of different
approaches (including existing status quo) and figure out a roadmap?

[Yang, 2016-10-07 14:05:55]

https://codereview.chromium.org/2396193002/diff/20001/include/v8-debug.h
File include/v8-debug.h (right):

https://codereview.chromium.org/2396193002/diff/20001/include/v8-debug.h#newc...
include/v8-debug.h:291: static void ChangeBreakOnException(Isolate* isolate,
On 2016/10/06 21:48:43, dgozman wrote:
> I wonder whether we want new public C++ api for debugging. This patch moves
api
> from js to native, which is good in some way, but maybe we just want
> "v8-inspector-only" api to avoid growing v8::Debug and leave wired protocol as
> "the api" ?
> 
> Yang, what's your view on this? Should we discuss pros and cons of different
> approaches (including existing status quo) and figure out a roadmap?

The idea that I have, but not really communicated yet, is to introduce a
src/debug/debug-api.h and src/debug/debug-api.cc as interface between inspector
and the debugger. Eventually, the inspector protocol should become the only
debugger API to outside of V8.

[kozy, 2016-10-17 15:35:13]

Please take another look!

[kozy, 2016-10-17 15:35:26]

Description was changed from

==========
[inspector] Move changeBreakpointState from debugger-script to native

* introduced v8::Debug::ChangeBreakOnException(Isolate*,ExceptionBreakState);
* migrated inspector to new API;
* added cctest for new API;
* added inspector test for setPauseOnExceptionState.

BUG=chromium:652939
R=dgozman@chromium.org,yangguo@chromium.org
==========

to

==========
[inspector] Move changeBreakpointState from debugger-script to native

* introduced
v8::DebugInterface::ChangeBreakOnException(Isolate*,ExceptionBreakState);
* migrated inspector to new API;
* added cctest for new API;
* added inspector test for setPauseOnExceptionState.

BUG=chromium:652939
R=dgozman@chromium.org,yangguo@chromium.org
==========

[kozy, 2016-10-17 16:11:32]

Description was changed from

==========
[inspector] Move changeBreakpointState from debugger-script to native

* introduced
v8::DebugInterface::ChangeBreakOnException(Isolate*,ExceptionBreakState);
* migrated inspector to new API;
* added cctest for new API;
* added inspector test for setPauseOnExceptionState.

BUG=chromium:652939
R=dgozman@chromium.org,yangguo@chromium.org
==========

to

==========
[inspector] Move changeBreakpointState from debugger-script to native

* introduced
v8::DebugInterface::ChangeBreakOnException(Isolate*,ExceptionBreakState);
* migrated inspector to new API;
* added cctest for new API;
* added inspector test for setPauseOnExceptionState.

BUG=chromium:652939,v8:5510
R=dgozman@chromium.org,yangguo@chromium.org
==========

[kozy, 2016-10-17 16:28:52]

Description was changed from

==========
[inspector] Move changeBreakpointState from debugger-script to native

* introduced
v8::DebugInterface::ChangeBreakOnException(Isolate*,ExceptionBreakState);
* migrated inspector to new API;
* added cctest for new API;
* added inspector test for setPauseOnExceptionState.

BUG=chromium:652939,v8:5510
R=dgozman@chromium.org,yangguo@chromium.org
==========

to

==========
[inspector] move changeBreakpointState from debugger-script to native

* introduced
v8::DebugInterface::ChangeBreakOnException(Isolate*,ExceptionBreakState);
* migrated inspector to new API;
* added cctest for new API;
* added inspector test for setPauseOnExceptionState.

BUG=chromium:652939,v8:5510
R=dgozman@chromium.org,yangguo@chromium.org
==========

[Yang, 2016-10-18 11:17:50]

On 2016/10/17 15:35:13, kozyatinskiy wrote:
> Please take another look!

lgtm.

[kozy, 2016-10-19 01:09:04]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-10-19 01:09:05]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2396193002/#ps60001
(title: "rebased")

[dgozman, 2016-10-19 01:24:57]

lgtm. Good stuff!

[commit-bot: I haz the power, 2016-10-19 01:31:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 02:00:29]

Description was changed from

==========
[inspector] move changeBreakpointState from debugger-script to native

* introduced
v8::DebugInterface::ChangeBreakOnException(Isolate*,ExceptionBreakState);
* migrated inspector to new API;
* added cctest for new API;
* added inspector test for setPauseOnExceptionState.

BUG=chromium:652939,v8:5510
R=dgozman@chromium.org,yangguo@chromium.org
==========

to

==========
[inspector] move changeBreakpointState from debugger-script to native

* introduced
v8::DebugInterface::ChangeBreakOnException(Isolate*,ExceptionBreakState);
* migrated inspector to new API;
* added cctest for new API;
* added inspector test for setPauseOnExceptionState.

BUG=chromium:652939,v8:5510
R=dgozman@chromium.org,yangguo@chromium.org
==========

[commit-bot: I haz the power, 2016-10-19 02:00:30]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-11-17 22:05:22]

Description was changed from

==========
[inspector] move changeBreakpointState from debugger-script to native

* introduced
v8::DebugInterface::ChangeBreakOnException(Isolate*,ExceptionBreakState);
* migrated inspector to new API;
* added cctest for new API;
* added inspector test for setPauseOnExceptionState.

BUG=chromium:652939,v8:5510
R=dgozman@chromium.org,yangguo@chromium.org
==========

to

==========
[inspector] move changeBreakpointState from debugger-script to native

* introduced
v8::DebugInterface::ChangeBreakOnException(Isolate*,ExceptionBreakState);
* migrated inspector to new API;
* added cctest for new API;
* added inspector test for setPauseOnExceptionState.

BUG=chromium:652939,v8:5510
R=dgozman@chromium.org,yangguo@chromium.org

Committed: https://crrev.com/377533fc06cb43e84a765775ebf057c053961973
Cr-Commit-Position: refs/heads/master@{#40413}
==========

[commit-bot: I haz the power, 2016-11-17 22:05:24]

Patchset 3 (id:??) landed as
https://crrev.com/377533fc06cb43e84a765775ebf057c053961973
Cr-Commit-Position: refs/heads/master@{#40413}