Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2396133002: Adding Pinned Tab and Preferences-specified Tab logic to Startup Flow refactor (Closed)

Created:
4 years, 2 months ago by tmartino
Modified:
4 years, 1 month ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, grt (UTC plus 2)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This patch fills in the TODOs in StartupTabProvider regarding pinned tabs and user preferences-specified default tabs. BUG=656139, 248883, 517248 Committed: https://crrev.com/f51ecc9beca2aadad233c44ed098406361d128a8 Cr-Commit-Position: refs/heads/master@{#426339}

Patch Set 1 #

Patch Set 2 : Rebase to include landed changes #

Patch Set 3 : Autoformatting #

Total comments: 8

Patch Set 4 : Correcting initializer nit #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -18 lines) Patch
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl_unittest.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_tab_provider.h View 1 3 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/ui/startup/startup_tab_provider.cc View 1 2 4 chunks +21 lines, -10 lines 2 comments Download
M chrome/browser/ui/startup/startup_tab_provider_unittest.cc View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
tmartino
Hi Peter, Here's the first follow-up to my refactor CL. It's fairly straightforward, filling in ...
4 years, 2 months ago (2016-10-17 18:38:09 UTC) #4
Peter Kasting
I left some thoughts on your doc about eliminating the deduping. I'm not sure whether ...
4 years, 2 months ago (2016-10-18 00:53:42 UTC) #5
Peter Kasting
Eliminating deduping also LGTM. https://codereview.chromium.org/2396133002/diff/40001/chrome/browser/ui/startup/startup_browser_creator_impl.cc File chrome/browser/ui/startup/startup_browser_creator_impl.cc (right): https://codereview.chromium.org/2396133002/diff/40001/chrome/browser/ui/startup/startup_browser_creator_impl.cc#newcode684 chrome/browser/ui/startup/startup_browser_creator_impl.cc:684: for (size_t j = 0; ...
4 years, 2 months ago (2016-10-19 21:17:56 UTC) #6
tmartino
https://codereview.chromium.org/2396133002/diff/40001/chrome/browser/ui/startup/startup_browser_creator_impl.cc File chrome/browser/ui/startup/startup_browser_creator_impl.cc (right): https://codereview.chromium.org/2396133002/diff/40001/chrome/browser/ui/startup/startup_browser_creator_impl.cc#newcode684 chrome/browser/ui/startup/startup_browser_creator_impl.cc:684: for (size_t j = 0; j < num_existing_tabs; ++j) ...
4 years, 2 months ago (2016-10-19 22:01:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396133002/60001
4 years, 2 months ago (2016-10-19 23:21:35 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-19 23:42:29 UTC) #15
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/f51ecc9beca2aadad233c44ed098406361d128a8 Cr-Commit-Position: refs/heads/master@{#426339}
4 years, 2 months ago (2016-10-21 13:13:23 UTC) #17
grt (UTC plus 2)
4 years, 1 month ago (2016-10-24 06:55:36 UTC) #18
Message was sent while issue was closed.
post-commit drive-by

https://codereview.chromium.org/2396133002/diff/60001/chrome/browser/ui/start...
File chrome/browser/ui/startup/startup_tab_provider.cc (right):

https://codereview.chromium.org/2396133002/diff/60001/chrome/browser/ui/start...
chrome/browser/ui/startup/startup_tab_provider.cc:110: SessionStartupPref pref)
{
should this be passed by const-ref since it contains a vector of GURLs?

https://codereview.chromium.org/2396133002/diff/60001/chrome/browser/ui/start...
chrome/browser/ui/startup/startup_tab_provider.cc:113: for (auto& url :
pref.urls)
nit: "const auto&"

Powered by Google App Engine
This is Rietveld 408576698