Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 23960004: Updated usrsctp to latest version with fixes upstream. Fixed usrsctp gyp file; removed overides. (Closed)

Created:
7 years, 3 months ago by ldixon
Modified:
7 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, juberti2
Visibility:
Public.

Description

Updated usrsctp to latest version (to 8603) with fixes upstream. Fixed usrsctp gyp file; removed overides. usrsctp update = 8554:8603 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221656

Patch Set 1 #

Patch Set 2 : Fixed for Mac #

Patch Set 3 : "updated to fix for mac building from upstream" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1818 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
D third_party/usrsctp/overrides/usrsctplib/netinet/sctp_auth.h View 1 chunk +0 lines, -223 lines 0 comments Download
D third_party/usrsctp/overrides/usrsctplib/netinet/sctp_nss_sha1.h View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/usrsctp/overrides/usrsctplib/netinet/sctp_nss_sha1.c View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/usrsctp/overrides/usrsctplib/netinet/sctp_openssl_sha1.h View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/usrsctp/overrides/usrsctplib/netinet/sctp_os.h View 1 chunk +0 lines, -95 lines 0 comments Download
D third_party/usrsctp/overrides/usrsctplib/netinet/sctp_os_userspace.h View 1 chunk +0 lines, -1162 lines 0 comments Download
D third_party/usrsctp/overrides/usrsctplib/netinet/sctp_sha1.h View 1 chunk +0 lines, -122 lines 0 comments Download
M third_party/usrsctp/usrsctp.gyp View 1 5 chunks +34 lines, -39 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ldixon
Hi, Code to fix usrsctp for windows. A separate CL for adding the HAVE_SCTP for ...
7 years, 3 months ago (2013-09-05 22:53:39 UTC) #1
Ronghua Wu (Left Chromium)
LGTM as soon as the bots are happy. Can you please add "8554:8603" to your ...
7 years, 3 months ago (2013-09-05 22:56:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ldixon@google.com/23960004/9001
7 years, 3 months ago (2013-09-05 23:41:33 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 08:58:56 UTC) #4
Message was sent while issue was closed.
Change committed as 221656

Powered by Google App Engine
This is Rietveld 408576698