Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1141)

Unified Diff: chrome/browser/drive/drive_api_service.cc

Issue 23958006: Use "Files: list" for full fetch. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/drive/change_list_loader.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/drive/drive_api_service.cc
diff --git a/chrome/browser/drive/drive_api_service.cc b/chrome/browser/drive/drive_api_service.cc
index 435fcb8e1d0bdabafffd85392ef74334f5c1cc02..dbc7325d1c4995a4cd45f71442533ffcd59950b7 100644
--- a/chrome/browser/drive/drive_api_service.cc
+++ b/chrome/browser/drive/drive_api_service.cc
@@ -319,15 +319,12 @@ CancelCallback DriveAPIService::GetAllResourceList(
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
DCHECK(!callback.is_null());
- // The simplest way to fetch the all resources list looks files.list method,
- // but it seems impossible to know the returned list's changestamp.
- // Thus, instead, we use changes.list method with includeDeleted=false here.
- // The returned list should contain only resources currently existing.
- ChangesListRequest* request = new ChangesListRequest(
+ FilesListRequest* request = new FilesListRequest(
sender_.get(), url_generator_,
- base::Bind(&ConvertChangeListToResourceListOnBlockingPoolAndRun,
+ base::Bind(&ConvertFileListToResourceListOnBlockingPoolAndRun,
blocking_task_runner_, callback));
- request->set_include_deleted(false);
+ request->set_max_results(kMaxNumFilesResourcePerRequest);
+ request->set_q("trashed = false"); // Exclude trashed files.
return sender_->StartRequestWithRetry(request);
}
« no previous file with comments | « chrome/browser/chromeos/drive/change_list_loader.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698