Issue 23958006: Use "Files: list" for full fetch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23958006: Use "Files: list" for full fetch. (Closed)

Created:
7 years, 3 months ago by hidehiko

Modified:
7 years, 3 months ago

Reviewers:
kinaba

CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use "Files: list" for full fetch. According to some investigation, "Files: list" should be faster than "Changes: list". We can use this because we extract change list id from "About: get" API. BUG=287602 TEST=Ran unit_tests and tested manually. WIP Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222016

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -11 lines)			Patch
	M	chrome/browser/chromeos/drive/change_list_loader.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
	M	chrome/browser/drive/drive_api_service.cc	View		1 chunk	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23958006/1

7 years, 3 months ago (2013-09-09 06:40:19 UTC) #3

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=76665

7 years, 3 months ago (2013-09-09 07:46:45 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23958006/1

7 years, 3 months ago (2013-09-09 08:13:27 UTC) #5

Message was sent while issue was closed.

Change committed as 222016

Expand Messages | Collapse Messages