Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: Source/core/svg/SVGTextPathElement.cpp

Issue 23956012: Stop passing NodeRenderingContext except in textRendererIsNeeded (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGTextPathElement.h ('k') | Source/core/svg/SVGTitleElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGTextPathElement.cpp
diff --git a/Source/core/svg/SVGTextPathElement.cpp b/Source/core/svg/SVGTextPathElement.cpp
index 2afd1c6d7137be248818a00b1d22373fe69221d7..b0f8b185c1da2d86617610c51c8b9d02713bcfdd 100644
--- a/Source/core/svg/SVGTextPathElement.cpp
+++ b/Source/core/svg/SVGTextPathElement.cpp
@@ -24,7 +24,6 @@
#include "SVGNames.h"
#include "XLinkNames.h"
-#include "core/dom/NodeRenderingContext.h"
#include "core/rendering/svg/RenderSVGResource.h"
#include "core/rendering/svg/RenderSVGTextPath.h"
#include "core/svg/SVGElementInstance.h"
@@ -132,23 +131,23 @@ RenderObject* SVGTextPathElement::createRenderer(RenderStyle*)
return new RenderSVGTextPath(this);
}
-bool SVGTextPathElement::childShouldCreateRenderer(const NodeRenderingContext& childContext) const
+bool SVGTextPathElement::childShouldCreateRenderer(const Node& child) const
{
- if (childContext.node()->isTextNode()
- || childContext.node()->hasTagName(SVGNames::aTag)
- || childContext.node()->hasTagName(SVGNames::trefTag)
- || childContext.node()->hasTagName(SVGNames::tspanTag))
+ if (child.isTextNode()
+ || child.hasTagName(SVGNames::aTag)
+ || child.hasTagName(SVGNames::trefTag)
+ || child.hasTagName(SVGNames::tspanTag))
return true;
return false;
}
-bool SVGTextPathElement::rendererIsNeeded(const NodeRenderingContext& context)
+bool SVGTextPathElement::rendererIsNeeded(const RenderStyle& style)
{
if (parentNode()
&& (parentNode()->hasTagName(SVGNames::aTag)
|| parentNode()->hasTagName(SVGNames::textTag)))
- return Element::rendererIsNeeded(context);
+ return Element::rendererIsNeeded(style);
return false;
}
« no previous file with comments | « Source/core/svg/SVGTextPathElement.h ('k') | Source/core/svg/SVGTitleElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698