Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: Source/core/svg/SVGTSpanElement.cpp

Issue 23956012: Stop passing NodeRenderingContext except in textRendererIsNeeded (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGTSpanElement.h ('k') | Source/core/svg/SVGTextElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGTSpanElement.cpp
diff --git a/Source/core/svg/SVGTSpanElement.cpp b/Source/core/svg/SVGTSpanElement.cpp
index 8d44699bf647eb19c863658403d764e7618acee7..43871754cff3ebbf960d3e9aa6b4d00dbd446bbc 100644
--- a/Source/core/svg/SVGTSpanElement.cpp
+++ b/Source/core/svg/SVGTSpanElement.cpp
@@ -23,7 +23,6 @@
#include "core/svg/SVGTSpanElement.h"
#include "SVGNames.h"
-#include "core/dom/NodeRenderingContext.h"
#include "core/rendering/svg/RenderSVGTSpan.h"
namespace WebCore {
@@ -45,21 +44,21 @@ RenderObject* SVGTSpanElement::createRenderer(RenderStyle*)
return new RenderSVGTSpan(this);
}
-bool SVGTSpanElement::childShouldCreateRenderer(const NodeRenderingContext& childContext) const
+bool SVGTSpanElement::childShouldCreateRenderer(const Node& child) const
{
- if (childContext.node()->isTextNode()
- || childContext.node()->hasTagName(SVGNames::aTag)
+ if (child.isTextNode()
+ || child.hasTagName(SVGNames::aTag)
#if ENABLE(SVG_FONTS)
- || childContext.node()->hasTagName(SVGNames::altGlyphTag)
+ || child.hasTagName(SVGNames::altGlyphTag)
#endif
- || childContext.node()->hasTagName(SVGNames::trefTag)
- || childContext.node()->hasTagName(SVGNames::tspanTag))
+ || child.hasTagName(SVGNames::trefTag)
+ || child.hasTagName(SVGNames::tspanTag))
return true;
return false;
}
-bool SVGTSpanElement::rendererIsNeeded(const NodeRenderingContext& context)
+bool SVGTSpanElement::rendererIsNeeded(const RenderStyle& style)
{
if (parentNode()
&& (parentNode()->hasTagName(SVGNames::aTag)
@@ -69,7 +68,7 @@ bool SVGTSpanElement::rendererIsNeeded(const NodeRenderingContext& context)
|| parentNode()->hasTagName(SVGNames::textTag)
|| parentNode()->hasTagName(SVGNames::textPathTag)
|| parentNode()->hasTagName(SVGNames::tspanTag)))
- return Element::rendererIsNeeded(context);
+ return Element::rendererIsNeeded(style);
return false;
}
« no previous file with comments | « Source/core/svg/SVGTSpanElement.h ('k') | Source/core/svg/SVGTextElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698