Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Unified Diff: Source/core/dom/NodeRenderingContext.cpp

Issue 23956012: Stop passing NodeRenderingContext except in textRendererIsNeeded (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/dom/PseudoElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/NodeRenderingContext.cpp
diff --git a/Source/core/dom/NodeRenderingContext.cpp b/Source/core/dom/NodeRenderingContext.cpp
index 008cb117f288051bc66aa54babca02d0c6769382..da6f56f840ce3ad2a1a2395f312adf55980d7f30 100644
--- a/Source/core/dom/NodeRenderingContext.cpp
+++ b/Source/core/dom/NodeRenderingContext.cpp
@@ -162,7 +162,7 @@ bool NodeRenderingContext::shouldCreateRenderer() const
return false;
if (!parentRenderer->canHaveChildren())
return false;
- if (!m_renderingParent->childShouldCreateRenderer(*this))
+ if (!m_renderingParent->childShouldCreateRenderer(*m_node))
return false;
return true;
}
@@ -182,7 +182,7 @@ bool NodeRenderingContext::elementInsideRegionNeedsRenderer()
elementInsideRegionNeedsRenderer = element->shouldMoveToFlowThread(m_style.get());
// Children of this element will only be allowed to be flowed into other flow-threads if display is NOT none.
- if (element->rendererIsNeeded(*this))
+ if (element->rendererIsNeeded(*m_style))
element->setIsInsideRegion(true);
}
@@ -224,7 +224,7 @@ void NodeRenderingContext::createRendererForElementIfNeeded()
moveToFlowThreadIfNeeded();
- if (!element->rendererIsNeeded(*this))
+ if (!element->rendererIsNeeded(*m_style))
return;
RenderObject* newRenderer = element->createRenderer(m_style.get());
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/dom/PseudoElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698