Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Side by Side Diff: Source/core/svg/SVGSVGElement.cpp

Issue 23956012: Stop passing NodeRenderingContext except in textRendererIsNeeded (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGSVGElement.h ('k') | Source/core/svg/SVGScriptElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 448 matching lines...) Expand 10 before | Expand all | Expand 10 after
459 LayoutSize scrollOffset = view->scrollOffset(); 459 LayoutSize scrollOffset = view->scrollOffset();
460 scrollOffset.scale(zoomFactor); 460 scrollOffset.scale(zoomFactor);
461 transform.translate(-scrollOffset.width(), -scrollOffset.height( )); 461 transform.translate(-scrollOffset.width(), -scrollOffset.height( ));
462 } 462 }
463 } 463 }
464 } 464 }
465 465
466 return transform.multiply(viewBoxTransform); 466 return transform.multiply(viewBoxTransform);
467 } 467 }
468 468
469 bool SVGSVGElement::rendererIsNeeded(const NodeRenderingContext& context) 469 bool SVGSVGElement::rendererIsNeeded(const RenderStyle& style)
470 { 470 {
471 // FIXME: We should respect display: none on the documentElement svg element 471 // FIXME: We should respect display: none on the documentElement svg element
472 // but many things in FrameView and SVGImage depend on the RenderSVGRoot whe n 472 // but many things in FrameView and SVGImage depend on the RenderSVGRoot whe n
473 // they should instead depend on the RenderView. 473 // they should instead depend on the RenderView.
474 // https://bugs.webkit.org/show_bug.cgi?id=103493 474 // https://bugs.webkit.org/show_bug.cgi?id=103493
475 if (document().documentElement() == this) 475 if (document().documentElement() == this)
476 return true; 476 return true;
477 return Element::rendererIsNeeded(context); 477 return Element::rendererIsNeeded(style);
478 } 478 }
479 479
480 RenderObject* SVGSVGElement::createRenderer(RenderStyle*) 480 RenderObject* SVGSVGElement::createRenderer(RenderStyle*)
481 { 481 {
482 if (isOutermostSVGSVGElement()) 482 if (isOutermostSVGSVGElement())
483 return new RenderSVGRoot(this); 483 return new RenderSVGRoot(this);
484 484
485 return new RenderSVGViewportContainer(this); 485 return new RenderSVGViewportContainer(this);
486 } 486 }
487 487
(...skipping 282 matching lines...) Expand 10 before | Expand all | Expand 10 after
770 continue; 770 continue;
771 771
772 Element* element = toElement(node); 772 Element* element = toElement(node);
773 if (element->getIdAttribute() == id) 773 if (element->getIdAttribute() == id)
774 return element; 774 return element;
775 } 775 }
776 return 0; 776 return 0;
777 } 777 }
778 778
779 } 779 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGSVGElement.h ('k') | Source/core/svg/SVGScriptElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698