Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Side by Side Diff: Source/core/svg/SVGElement.h

Issue 23956012: Stop passing NodeRenderingContext except in textRendererIsNeeded (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGDocument.cpp ('k') | Source/core/svg/SVGElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * Copyright (C) 2009 Apple Inc. All rights reserved. 4 * Copyright (C) 2009 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 133
134 virtual bool shouldMoveToFlowThread(RenderStyle*) const OVERRIDE; 134 virtual bool shouldMoveToFlowThread(RenderStyle*) const OVERRIDE;
135 135
136 protected: 136 protected:
137 SVGElement(const QualifiedName&, Document&, ConstructionType = CreateSVGElem ent); 137 SVGElement(const QualifiedName&, Document&, ConstructionType = CreateSVGElem ent);
138 138
139 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE; 139 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE;
140 140
141 virtual void finishParsingChildren(); 141 virtual void finishParsingChildren();
142 virtual void attributeChanged(const QualifiedName&, const AtomicString&, Att ributeModificationReason = ModifiedDirectly) OVERRIDE; 142 virtual void attributeChanged(const QualifiedName&, const AtomicString&, Att ributeModificationReason = ModifiedDirectly) OVERRIDE;
143 virtual bool childShouldCreateRenderer(const NodeRenderingContext&) const OV ERRIDE; 143 virtual bool childShouldCreateRenderer(const Node& child) const OVERRIDE;
144 144
145 virtual bool isPresentationAttribute(const QualifiedName&) const OVERRIDE; 145 virtual bool isPresentationAttribute(const QualifiedName&) const OVERRIDE;
146 virtual void collectStyleForPresentationAttribute(const QualifiedName&, cons t AtomicString&, MutableStylePropertySet*) OVERRIDE; 146 virtual void collectStyleForPresentationAttribute(const QualifiedName&, cons t AtomicString&, MutableStylePropertySet*) OVERRIDE;
147 virtual bool rendererIsNeeded(const NodeRenderingContext&) OVERRIDE; 147 virtual bool rendererIsNeeded(const RenderStyle&) OVERRIDE;
148 148
149 virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE; 149 virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE;
150 virtual void removedFrom(ContainerNode*) OVERRIDE; 150 virtual void removedFrom(ContainerNode*) OVERRIDE;
151 virtual void childrenChanged(bool changedByParser = false, Node* beforeChang e = 0, Node* afterChange = 0, int childCountDelta = 0); 151 virtual void childrenChanged(bool changedByParser = false, Node* beforeChang e = 0, Node* afterChange = 0, int childCountDelta = 0);
152 152
153 static CSSPropertyID cssPropertyIdForSVGAttributeName(const QualifiedName&); 153 static CSSPropertyID cssPropertyIdForSVGAttributeName(const QualifiedName&);
154 void updateRelativeLengthsInformation() { updateRelativeLengthsInformation(s elfHasRelativeLengths(), this); } 154 void updateRelativeLengthsInformation() { updateRelativeLengthsInformation(s elfHasRelativeLengths(), this); }
155 void updateRelativeLengthsInformation(bool hasRelativeLengths, SVGElement*); 155 void updateRelativeLengthsInformation(bool hasRelativeLengths, SVGElement*);
156 156
157 virtual bool selfHasRelativeLengths() const { return false; } 157 virtual bool selfHasRelativeLengths() const { return false; }
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 208
209 inline const SVGElement* toSVGElement(const Node* node) 209 inline const SVGElement* toSVGElement(const Node* node)
210 { 210 {
211 ASSERT_WITH_SECURITY_IMPLICATION(!node || node->isSVGElement()); 211 ASSERT_WITH_SECURITY_IMPLICATION(!node || node->isSVGElement());
212 return static_cast<const SVGElement*>(node); 212 return static_cast<const SVGElement*>(node);
213 } 213 }
214 214
215 } 215 }
216 216
217 #endif 217 #endif
OLDNEW
« no previous file with comments | « Source/core/svg/SVGDocument.cpp ('k') | Source/core/svg/SVGElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698