Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: Source/core/svg/SVGAElement.cpp

Issue 23956012: Stop passing NodeRenderingContext except in textRendererIsNeeded (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGAElement.h ('k') | Source/core/svg/SVGAltGlyphDefElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 14 matching lines...) Expand all
25 #include "core/svg/SVGAElement.h" 25 #include "core/svg/SVGAElement.h"
26 26
27 #include "SVGNames.h" 27 #include "SVGNames.h"
28 #include "XLinkNames.h" 28 #include "XLinkNames.h"
29 #include "core/dom/Attr.h" 29 #include "core/dom/Attr.h"
30 #include "core/dom/Attribute.h" 30 #include "core/dom/Attribute.h"
31 #include "core/dom/Document.h" 31 #include "core/dom/Document.h"
32 #include "core/dom/EventNames.h" 32 #include "core/dom/EventNames.h"
33 #include "core/dom/KeyboardEvent.h" 33 #include "core/dom/KeyboardEvent.h"
34 #include "core/dom/MouseEvent.h" 34 #include "core/dom/MouseEvent.h"
35 #include "core/dom/NodeRenderingContext.h"
36 #include "core/html/HTMLAnchorElement.h" 35 #include "core/html/HTMLAnchorElement.h"
37 #include "core/html/HTMLFormElement.h" 36 #include "core/html/HTMLFormElement.h"
38 #include "core/html/parser/HTMLParserIdioms.h" 37 #include "core/html/parser/HTMLParserIdioms.h"
39 #include "core/loader/FrameLoadRequest.h" 38 #include "core/loader/FrameLoadRequest.h"
40 #include "core/loader/FrameLoader.h" 39 #include "core/loader/FrameLoader.h"
41 #include "core/loader/FrameLoaderTypes.h" 40 #include "core/loader/FrameLoaderTypes.h"
42 #include "core/page/Chrome.h" 41 #include "core/page/Chrome.h"
43 #include "core/page/ChromeClient.h" 42 #include "core/page/ChromeClient.h"
44 #include "core/page/Frame.h" 43 #include "core/page/Frame.h"
45 #include "core/page/Page.h" 44 #include "core/page/Page.h"
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 bool SVGAElement::isKeyboardFocusable() const 219 bool SVGAElement::isKeyboardFocusable() const
221 { 220 {
222 if (!isFocusable()) 221 if (!isFocusable())
223 return false; 222 return false;
224 223
225 if (Page* page = document().page()) 224 if (Page* page = document().page())
226 return page->chrome().client().tabsToLinks(); 225 return page->chrome().client().tabsToLinks();
227 return false; 226 return false;
228 } 227 }
229 228
230 bool SVGAElement::childShouldCreateRenderer(const NodeRenderingContext& childCon text) const 229 bool SVGAElement::childShouldCreateRenderer(const Node& child) const
231 { 230 {
232 // http://www.w3.org/2003/01/REC-SVG11-20030114-errata#linking-text-environm ent 231 // http://www.w3.org/2003/01/REC-SVG11-20030114-errata#linking-text-environm ent
233 // The 'a' element may contain any element that its parent may contain, exce pt itself. 232 // The 'a' element may contain any element that its parent may contain, exce pt itself.
234 if (childContext.node()->hasTagName(SVGNames::aTag)) 233 if (child.hasTagName(SVGNames::aTag))
235 return false; 234 return false;
236 if (parentNode() && parentNode()->isSVGElement()) 235 if (parentNode() && parentNode()->isSVGElement())
237 return parentNode()->childShouldCreateRenderer(childContext); 236 return parentNode()->childShouldCreateRenderer(child);
238 237
239 return SVGElement::childShouldCreateRenderer(childContext); 238 return SVGElement::childShouldCreateRenderer(child);
240 } 239 }
241 240
242 } // namespace WebCore 241 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/svg/SVGAElement.h ('k') | Source/core/svg/SVGAltGlyphDefElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698