Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: Source/core/html/HTMLSelectElement.h

Issue 23956012: Stop passing NodeRenderingContext except in textRendererIsNeeded (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLProgressElement.cpp ('k') | Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2000 Dirk Mueller (mueller@kde.org) 5 * (C) 2000 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 129
130 virtual bool isEnumeratable() const { return true; } 130 virtual bool isEnumeratable() const { return true; }
131 virtual bool supportLabels() const OVERRIDE { return true; } 131 virtual bool supportLabels() const OVERRIDE { return true; }
132 132
133 virtual FormControlState saveFormControlState() const OVERRIDE; 133 virtual FormControlState saveFormControlState() const OVERRIDE;
134 virtual void restoreFormControlState(const FormControlState&) OVERRIDE; 134 virtual void restoreFormControlState(const FormControlState&) OVERRIDE;
135 135
136 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE; 136 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE;
137 virtual bool isPresentationAttribute(const QualifiedName&) const OVERRIDE; 137 virtual bool isPresentationAttribute(const QualifiedName&) const OVERRIDE;
138 138
139 virtual bool childShouldCreateRenderer(const NodeRenderingContext&) const OV ERRIDE; 139 virtual bool childShouldCreateRenderer(const Node& child) const OVERRIDE;
140 virtual RenderObject* createRenderer(RenderStyle *); 140 virtual RenderObject* createRenderer(RenderStyle *);
141 virtual bool appendFormData(FormDataList&, bool); 141 virtual bool appendFormData(FormDataList&, bool);
142 142
143 virtual void defaultEventHandler(Event*); 143 virtual void defaultEventHandler(Event*);
144 144
145 void dispatchChangeEventForMenuList(); 145 void dispatchChangeEventForMenuList();
146 146
147 void recalcListItems(bool updateSelectedStates = true) const; 147 void recalcListItems(bool updateSelectedStates = true) const;
148 148
149 void deselectItems(HTMLOptionElement* excludeElement = 0); 149 void deselectItems(HTMLOptionElement* excludeElement = 0);
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 { 214 {
215 ASSERT_WITH_SECURITY_IMPLICATION(!node || node->hasTagName(HTMLNames::select Tag)); 215 ASSERT_WITH_SECURITY_IMPLICATION(!node || node->hasTagName(HTMLNames::select Tag));
216 return static_cast<HTMLSelectElement*>(node); 216 return static_cast<HTMLSelectElement*>(node);
217 } 217 }
218 218
219 void toHTMLSelectElement(const HTMLSelectElement*); // This overload will catch anyone doing an unnecessary cast. 219 void toHTMLSelectElement(const HTMLSelectElement*); // This overload will catch anyone doing an unnecessary cast.
220 220
221 } // namespace 221 } // namespace
222 222
223 #endif 223 #endif
OLDNEW
« no previous file with comments | « Source/core/html/HTMLProgressElement.cpp ('k') | Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698