Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: Source/core/dom/PseudoElement.cpp

Issue 23956012: Stop passing NodeRenderingContext except in textRendererIsNeeded (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/PseudoElement.h ('k') | Source/core/dom/shadow/InsertionPoint.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Neither the name of Google Inc. nor the names of its 10 * * Neither the name of Google Inc. nor the names of its
11 * contributors may be used to endorse or promote products derived from 11 * contributors may be used to endorse or promote products derived from
12 * this software without specific prior written permission. 12 * this software without specific prior written permission.
13 * 13 *
14 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 14 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
15 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 15 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
16 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 16 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
17 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 17 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
18 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 18 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
19 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 19 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
20 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 20 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
21 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 21 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
22 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 22 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
25 */ 25 */
26 26
27 #include "config.h" 27 #include "config.h"
28 #include "core/dom/PseudoElement.h" 28 #include "core/dom/PseudoElement.h"
29 29
30 #include "core/dom/NodeRenderingContext.h"
31 #include "core/rendering/RenderObject.h" 30 #include "core/rendering/RenderObject.h"
32 #include "core/rendering/RenderQuote.h" 31 #include "core/rendering/RenderQuote.h"
33 #include "core/rendering/style/ContentData.h" 32 #include "core/rendering/style/ContentData.h"
34 33
35 namespace WebCore { 34 namespace WebCore {
36 35
37 const QualifiedName& pseudoElementTagName() 36 const QualifiedName& pseudoElementTagName()
38 { 37 {
39 DEFINE_STATIC_LOCAL(QualifiedName, name, (nullAtom, "<pseudo>", nullAtom)); 38 DEFINE_STATIC_LOCAL(QualifiedName, name, (nullAtom, "<pseudo>", nullAtom));
40 return name; 39 return name;
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 RenderObject* child = content->createRenderer(document(), style); 91 RenderObject* child = content->createRenderer(document(), style);
93 if (renderer->isChildAllowed(child, style)) { 92 if (renderer->isChildAllowed(child, style)) {
94 renderer->addChild(child); 93 renderer->addChild(child);
95 if (child->isQuote()) 94 if (child->isQuote())
96 toRenderQuote(child)->attachQuote(); 95 toRenderQuote(child)->attachQuote();
97 } else 96 } else
98 child->destroy(); 97 child->destroy();
99 } 98 }
100 } 99 }
101 100
102 bool PseudoElement::rendererIsNeeded(const NodeRenderingContext& context) 101 bool PseudoElement::rendererIsNeeded(const RenderStyle& style)
103 { 102 {
104 return pseudoElementRendererIsNeeded(context.style()); 103 return pseudoElementRendererIsNeeded(&style);
105 } 104 }
106 105
107 void PseudoElement::didRecalcStyle(StyleRecalcChange) 106 void PseudoElement::didRecalcStyle(StyleRecalcChange)
108 { 107 {
109 if (!renderer()) 108 if (!renderer())
110 return; 109 return;
111 110
112 // The renderers inside pseudo elements are anonymous so they don't get noti fied of recalcStyle and must have 111 // The renderers inside pseudo elements are anonymous so they don't get noti fied of recalcStyle and must have
113 // the style propagated downward manually similar to RenderObject::propagate StyleToAnonymousChildren. 112 // the style propagated downward manually similar to RenderObject::propagate StyleToAnonymousChildren.
114 RenderObject* renderer = this->renderer(); 113 RenderObject* renderer = this->renderer();
115 for (RenderObject* child = renderer->nextInPreOrder(renderer); child; child = child->nextInPreOrder(renderer)) { 114 for (RenderObject* child = renderer->nextInPreOrder(renderer); child; child = child->nextInPreOrder(renderer)) {
116 // We only manage the style for the generated content items. 115 // We only manage the style for the generated content items.
117 if (!child->isText() && !child->isQuote() && !child->isImage()) 116 if (!child->isText() && !child->isQuote() && !child->isImage())
118 continue; 117 continue;
119 118
120 // The style for the RenderTextFragment for first letter is managed by a n enclosing block, not by us. 119 // The style for the RenderTextFragment for first letter is managed by a n enclosing block, not by us.
121 if (child->style()->styleType() == FIRST_LETTER) 120 if (child->style()->styleType() == FIRST_LETTER)
122 continue; 121 continue;
123 122
124 child->setPseudoStyle(renderer->style()); 123 child->setPseudoStyle(renderer->style());
125 } 124 }
126 } 125 }
127 126
128 } // namespace 127 } // namespace
OLDNEW
« no previous file with comments | « Source/core/dom/PseudoElement.h ('k') | Source/core/dom/shadow/InsertionPoint.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698