Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Side by Side Diff: Source/devtools/front_end/ConsoleMessage.js

Issue 23956003: DevTools: Add a fallback for console message callframe linkifying when scriptId could not be resolv… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Removed unresolved call frame altogether Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/inspector/console/console-error-on-call-frame-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 788 matching lines...) Expand 10 before | Expand all | Expand 10 after
799 var content = document.createElement("div"); 799 var content = document.createElement("div");
800 var messageTextElement = document.createElement("span"); 800 var messageTextElement = document.createElement("span");
801 messageTextElement.className = "console-message-text source-code"; 801 messageTextElement.className = "console-message-text source-code";
802 var functionName = frame.functionName || WebInspector.UIString("(ano nymous function)"); 802 var functionName = frame.functionName || WebInspector.UIString("(ano nymous function)");
803 messageTextElement.appendChild(document.createTextNode(functionName) ); 803 messageTextElement.appendChild(document.createTextNode(functionName) );
804 content.appendChild(messageTextElement); 804 content.appendChild(messageTextElement);
805 805
806 if (frame.scriptId) { 806 if (frame.scriptId) {
807 content.appendChild(document.createTextNode(" ")); 807 content.appendChild(document.createTextNode(" "));
808 var urlElement = this._linkifyCallFrame(frame); 808 var urlElement = this._linkifyCallFrame(frame);
809 if (!urlElement)
810 continue;
809 content.appendChild(urlElement); 811 content.appendChild(urlElement);
810 } 812 }
811 813
812 var treeElement = new TreeElement(content); 814 var treeElement = new TreeElement(content);
813 parentTreeElement.appendChild(treeElement); 815 parentTreeElement.appendChild(treeElement);
814 } 816 }
815 }, 817 },
816 818
817 updateRepeatCount: function() { 819 updateRepeatCount: function() {
818 if (!this._element) 820 if (!this._element)
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
967 /** 969 /**
968 * @return {WebInspector.ConsoleMessage} 970 * @return {WebInspector.ConsoleMessage}
969 */ 971 */
970 clone: function() 972 clone: function()
971 { 973 {
972 return WebInspector.ConsoleMessage.create(this.source, this.level, this. _messageText, this.type, this.url, this.line, this.column, this.repeatCount, thi s._parameters, this._stackTrace, this._request ? this._request.requestId : undef ined, this._isOutdated); 974 return WebInspector.ConsoleMessage.create(this.source, this.level, this. _messageText, this.type, this.url, this.line, this.column, this.repeatCount, thi s._parameters, this._stackTrace, this._request ? this._request.requestId : undef ined, this._isOutdated);
973 }, 975 },
974 976
975 __proto__: WebInspector.ConsoleMessage.prototype 977 __proto__: WebInspector.ConsoleMessage.prototype
976 } 978 }
OLDNEW
« no previous file with comments | « LayoutTests/inspector/console/console-error-on-call-frame-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698