Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2395263005: DevTools: minor cleanup of ConsoleViewMessage, use switch for formatters (Closed)

Created:
4 years, 2 months ago by luoe
Modified:
4 years, 2 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: minor cleanup of ConsoleViewMessage, use switch for formatters Formatters for different RemoteObject types are now handled via a switch statement over types. Type values come from: v8/src/inspector/protocol/Runtime.cpp Committed: https://crrev.com/e72b121a489a27e8a960f3bd3b81d83e238a5864 Cr-Commit-Position: refs/heads/master@{#424009}

Patch Set 1 #

Patch Set 2 : remove unnecessary bindings #

Messages

Total messages: 15 (10 generated)
luoe
The only functional changes are the switch statement with new cases. Eeverything else is moving ...
4 years, 2 months ago (2016-10-07 19:53:34 UTC) #3
lushnikov
lgtm
4 years, 2 months ago (2016-10-07 22:15:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395263005/20001
4 years, 2 months ago (2016-10-07 23:17:39 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-07 23:24:20 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 23:26:07 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e72b121a489a27e8a960f3bd3b81d83e238a5864
Cr-Commit-Position: refs/heads/master@{#424009}

Powered by Google App Engine
This is Rietveld 408576698