chrome/test/mini_installer/uninstall_chrome.py - Issue 23950004: Uninstall Chrome silently in the mini_installer test framework.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/mini_installer/uninstall_chrome.py

Issue 23950004: Uninstall Chrome silently in the mini_installer test framework. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/mini_installer/uninstall_chrome.py

diff --git a/chrome/test/mini_installer/uninstall_chrome.py b/chrome/test/mini_installer/uninstall_chrome.py

index 4cdd54e94146dfac4f817e33657a6408b79654d0..f501856737d1b6eee8869193cbe9d83e7013d2c4 100644

--- a/chrome/test/mini_installer/uninstall_chrome.py

+++ b/chrome/test/mini_installer/uninstall_chrome.py

@@ -38,7 +38,8 @@ def main():

'HKEY_LOCAL_MACHINE' if options.system_level else 'HKEY_CURRENT_USER',

sub_key))

uninstall_string, _ = _winreg.QueryValueEx(key, 'UninstallString')

- exit_status = subprocess.call(uninstall_string, shell=True)

+ exit_status = subprocess.call(uninstall_string + ' --force-uninstall',

+ shell=True)

# The exit status for successful uninstallation of Chrome is 19 (see

# chrome/installer/util/util_constants.h).

if exit_status != 19:

« no previous file with comments | « no previous file | no next file » | no next file with comments »