Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1439)

Issue 23950004: Uninstall Chrome silently in the mini_installer test framework. (Closed)

Created:
7 years, 3 months ago by sukolsak
Modified:
7 years, 3 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Uninstall Chrome silently in the mini_installer test framework. When the framework tried to uninstall Chrome, it would prompt the user with a dialog box saying that "Are you sure you want to uninstall Google Chrome? [ ] Also delete your browsing data?". This required a user action. Make it uninstall Chrome silently by using the --force-uninstall option. NOTRY=True BUG=264859 TEST= 1) Uninstall Chrome (if it's installed.) 2) Build Chrome with Release mode and make sure that mini_installer.exe is created. 3) Go to src\chrome\test\mini_installer 4) Run "python test_installer.py config\config.config --build-dir=<build-dir> --target=Release" where <build-dir> is the path to main build directory (the parent of the Release directory). The test should pass without requiring you to click anything. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221362

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/test/mini_installer/uninstall_chrome.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
sukolsak
Could you please take a look?
7 years, 3 months ago (2013-09-04 18:47:45 UTC) #1
gab
That makes sense to me, it forces: killing all current chrome.exe processes, no launching of ...
7 years, 3 months ago (2013-09-04 22:20:13 UTC) #2
gab
Oh... and lgtm :)!
7 years, 3 months ago (2013-09-04 22:20:24 UTC) #3
grt (UTC plus 2)
lgtm
7 years, 3 months ago (2013-09-04 23:22:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sukolsak@chromium.org/23950004/1
7 years, 3 months ago (2013-09-05 00:11:13 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-05 00:40:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sukolsak@chromium.org/23950004/1
7 years, 3 months ago (2013-09-05 03:42:22 UTC) #7
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=82996
7 years, 3 months ago (2013-09-05 04:10:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sukolsak@chromium.org/23950004/1
7 years, 3 months ago (2013-09-05 04:19:08 UTC) #9
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=83020
7 years, 3 months ago (2013-09-05 04:47:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sukolsak@chromium.org/23950004/1
7 years, 3 months ago (2013-09-05 05:06:25 UTC) #11
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=83042
7 years, 3 months ago (2013-09-05 05:32:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sukolsak@chromium.org/23950004/1
7 years, 3 months ago (2013-09-05 06:16:33 UTC) #13
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=83069
7 years, 3 months ago (2013-09-05 06:43:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sukolsak@chromium.org/23950004/1
7 years, 3 months ago (2013-09-05 06:45:55 UTC) #15
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=83086
7 years, 3 months ago (2013-09-05 07:14:09 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sukolsak@chromium.org/23950004/1
7 years, 3 months ago (2013-09-05 07:33:11 UTC) #17
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 07:35:02 UTC) #18
Message was sent while issue was closed.
Change committed as 221362

Powered by Google App Engine
This is Rietveld 408576698