Create WebContentsObserver callbacks for notifications, remove notifications from SSLManager.

Create WebContentsObserver callbacks for notifications, remove notifications from SSLManager.

BUG=82582, 170921
TEST=no functional change
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221342

[jam, 2013-09-04 22:33:05]

lgtm

just to check, are you doing this now and updating the callers in a followup?
(i.e. the timeline to remove the old notification is in days?)

[Avi (use Gerrit), 2013-09-04 23:26:11]

On 2013/09/04 22:33:05, jam wrote:
> lgtm
> 
> just to check, are you doing this now and updating the callers in a followup?
> (i.e. the timeline to remove the old notification is in days?)

The timeline is weeks. Some of those notifications are used in a handful of
places, other in a LOT. The idea is, as I need to, to promote notifications to
observer methods, and then switch the clients. As I switch the last client I'll
delete the constant.

But I don't want to promise how soon I'll be done :)

[commit-bot: I haz the power, 2013-09-04 23:33:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/23947003/12001

[commit-bot: I haz the power, 2013-09-05 00:33:46]

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-09-05 00:41:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/23947003/12001

[commit-bot: I haz the power, 2013-09-05 01:16:25]

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-09-05 02:05:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/23947003/12001

[commit-bot: I haz the power, 2013-09-05 02:35:54]

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-09-05 03:14:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/23947003/12001

[commit-bot: I haz the power, 2013-09-05 03:42:04]

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[Avi (use Gerrit), 2013-09-05 03:46:28]

On 2013/09/05 03:42:04, I haz the power (commit-bot) wrote:
> Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

Oh, c'mon. This is broken for everyone. NOTRYing.

[commit-bot: I haz the power, 2013-09-05 03:47:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/23947003/12001

[commit-bot: I haz the power, 2013-09-05 04:21:19]

Change committed as 221342