chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java - Issue 2394663002: Blimp: Propagating page loading status to tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

Issue 2394663002: Blimp: Propagating page loading status to tab (Closed)

Patch Set: dtrainor@ comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

index 7022ef318d8d07909215a9e15830a78a08f042f5..0fa7be7cf8d2fcb1e64a04d19b7951034d53f595 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

@@ -377,8 +377,7 @@ public class WebappActivity extends FullScreenActivity {

@Override

public void onDidStartProvisionalLoadForFrame(

- Tab tab, long frameId, long parentFrameId, boolean isMainFrame,

- String validatedUrl, boolean isErrorPage, boolean isIframeSrcdoc) {

+ Tab tab, boolean isMainFrame, String validatedUrl) {

if (isMainFrame) updateUrlBar();

}

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java ('k') | no next file » | no next file with comments »