chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java - Issue 2394663002: Blimp: Propagating page loading status to tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

Issue 2394663002: Blimp: Propagating page loading status to tab (Closed)

Patch Set: dtrainor@ comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

index 3bb8a4e73d61d3298cd323f3dac961c034465c39..dc426e1ebff4f91d3e6d25c4a9173c9a0ac4beae 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

@@ -189,11 +189,7 @@ public class TabWebContentsObserver extends WebContentsObserver {

boolean isIframeSrcdoc) {

if (isMainFrame) mTab.didStartPageLoad(validatedUrl, isErrorPage);

- RewindableIterator<TabObserver> observers = mTab.getTabObservers();

- while (observers.hasNext()) {

- observers.next().onDidStartProvisionalLoadForFrame(mTab, frameId, parentFrameId,

- isMainFrame, validatedUrl, isErrorPage, isIframeSrcdoc);

- }

+ mTab.handleDidStartProvisionalLoadForFrame(isMainFrame, validatedUrl);

}

@Override