chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java - Issue 2394663002: Blimp: Propagating page loading status to tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java

Issue 2394663002: Blimp: Propagating page loading status to tab (Closed)

Patch Set: dtrainor@ comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java

index e5636bde5ad70ad8ad201da0c1ba64f68a485b3c..03d67d4fd5faf29fa9c28b4f97f03a4fcb3794c4 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java

@@ -89,9 +89,8 @@ public class EmptyTabObserver implements TabObserver {

int errorCode, String description, String failingUrl) { }

@Override

- public void onDidStartProvisionalLoadForFrame(Tab tab, long frameId, long parentFrameId,

- boolean isMainFrame, String validatedUrl, boolean isErrorPage,

- boolean isIframeSrcdoc) { }

+ public void onDidStartProvisionalLoadForFrame(

+ Tab tab, boolean isMainFrame, String validatedUrl) {}

@Override

public void onDidCommitProvisionalLoadForFrame(Tab tab, long frameId, boolean isMainFrame,

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('j') | no next file with comments »