Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Unified Diff: chrome/browser/google_apis/base_requests.h

Issue 23944014: Remove unused parameter from a google_api::Request method. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/google_apis/base_requests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/google_apis/base_requests.h
diff --git a/chrome/browser/google_apis/base_requests.h b/chrome/browser/google_apis/base_requests.h
index d30f6a0426a279d51cdd8d7b3faf5bc726945c92..b0eec46202d9c7eef30bea147fba672a9cb04ec0 100644
--- a/chrome/browser/google_apis/base_requests.h
+++ b/chrome/browser/google_apis/base_requests.h
@@ -138,8 +138,8 @@ class UrlFetchRequestBase : public AuthenticatedRequestInterface,
// a user request. Must be implemented by a derived class.
virtual void RunCallbackOnPrematureFailure(GDataErrorCode code) = 0;
- // Invoked when ProcessURLFetchResults() is completed.
- void OnProcessURLFetchResultsComplete(bool result);
+ // Invoked from derived classes when ProcessURLFetchResults() is completed.
+ void OnProcessURLFetchResultsComplete();
// Returns an appropriate GDataErrorCode based on the HTTP response code and
// the status of the URLFetcher.
@@ -223,11 +223,6 @@ class GetDataRequest : public UrlFetchRequestBase {
GDataErrorCode fetch_error_code) OVERRIDE;
private:
- // Runs |callback_| with the given parameters.
- void RunCallbackOnSuccess(GDataErrorCode fetch_error_code,
- scoped_ptr<base::Value> value);
-
-
// Called when ParseJsonOnBlockingPool() is completed.
void OnDataParsed(GDataErrorCode fetch_error_code,
scoped_ptr<base::Value> value);
« no previous file with comments | « no previous file | chrome/browser/google_apis/base_requests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698