Issue 23942002: file_manager: Remove file_manager_extension=0 section from chrome_browser_chromeos.gypi

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23942002: file_manager: Remove file_manager_extension=0 section from chrome_browser_chromeos.gypi (Closed)

Created:
7 years, 3 months ago by satorux1

Modified:
7 years, 3 months ago

Reviewers:
hidehiko

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

file_manager: Remove file_manager_extension=0 section from chrome_browser_chromeos.gypi This configuration has been broken for long time, and fixing it is a non-trivial work without much benefit. For now, let's simplify the GYPI file so we don't have to touch the broken part. BUG=273386 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221286

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -18 lines)			Patch
	M	chrome/chrome_browser_chromeos.gypi	View		1 chunk	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/23942002/1

7 years, 3 months ago (2013-09-04 16:39:19 UTC) #3

Message was sent while issue was closed.

Change committed as 221286

Expand Messages | Collapse Messages