Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2393773003: Remove SVN support from gclient_utils and gclient_scm (Closed)

Created:
4 years, 2 months ago by agable
Modified:
4 years, 2 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove SVN support from gclient_utils and gclient_scm This removes SVN support (most notably the SVNWrapper class, and the git-svn logic in GitWrapper.GetUsableRev) from gclient_scm. It also removes some references to SVN from comments in gclient_utils. R=maruel@chromium.org BUG=641588 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/41e3a6c5530893d6c6046fa620fe5f335a4ef418

Patch Set 1 #

Patch Set 2 : Updated patchset dependency #

Patch Set 3 : Updated patchset dependency #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -674 lines) Patch
M gclient_scm.py View 1 2 3 4 10 chunks +35 lines, -569 lines 0 comments Download
M gclient_utils.py View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M tests/gclient_scm_test.py View 1 2 6 chunks +7 lines, -88 lines 0 comments Download
M tests/gclient_smoketest.py View 1 2 4 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
agable
This is the second small piece. I'm sending many of the other (non-gclient-specific) pieces to ...
4 years, 2 months ago (2016-10-05 21:07:16 UTC) #1
M-A Ruel
lgtm but let's https://codereview.chromium.org/2398493004/ bake for a few days before committing this CL.
4 years, 2 months ago (2016-10-05 21:14:57 UTC) #2
agable
Previous CL has baked for ~3 days. One piece of small fallout which was quickly ...
4 years, 2 months ago (2016-10-20 18:32:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393773003/80001
4 years, 2 months ago (2016-10-20 18:33:41 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-20 18:36:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/41e3a6c5530893...

Powered by Google App Engine
This is Rietveld 408576698