Issue 23936010: [Android Buildbot] Install ContentShell.apk before running GPU tests.

Issue 23936010: [Android Buildbot] Install ContentShell.apk before running GPU tests. (Closed)

Created:
7 years, 3 months ago by Siva Chandra

Modified:
7 years, 3 months ago

Reviewers:
cmp, Isaac (away), Sami

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android Buildbot] Install ContentShell.apk before running GPU tests. BUG=256576 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223230

Patch Set 2 : Use InstallApk function #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	build/android/buildbot/bb_device_steps.py	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Isaac (away)

There's a function that does this. I'm confused why you're copying the code instead. lgtm ...

7 years, 3 months ago (2013-09-13 10:09:45 UTC) #3

Siva Chandra

https://chromiumcodereview.appspot.com/23936010/diff/1/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://chromiumcodereview.appspot.com/23936010/diff/1/build/android/buildbot/bb_device_steps.py#newcode321 build/android/buildbot/bb_device_steps.py:321: args = ['--apk', 'ContentShell.apk', On 2013/09/13 10:09:45, Isaac wrote: ...

7 years, 3 months ago (2013-09-14 00:00:41 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/23936010/7001

7 years, 3 months ago (2013-09-14 00:03:02 UTC) #5

Message was sent while issue was closed.

Change committed as 223230

Expand Messages | Collapse Messages