Issue 23936004: This fixes the component build.

Issue 23936004: This fixes the component build. (Closed)

Created:
7 years, 3 months ago by David Trainor- moved to gerrit

Modified:
7 years, 3 months ago

Reviewers:
craigdh, cjhopman

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

This fixes the component build. Need to pass the CONFIGURATION_NAME through to the push python libs. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222171

Patch Set 2 : Added another config requirement point #

Patch Set 3 : Back to big fix! #

Patch Set 4 : Rebased #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -1 line)			Patch
M	build/android/gyp/apk_install.py	View	1	3 chunks	+5 lines, -0 lines	0 comments	Download
M	build/android/gyp/create_device_library_links.py	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	build/android/gyp/push_libraries.py	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download
M	build/android/push_libraries.gypi	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	build/java_apk.gypi	View	1	3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

David Trainor- moved to gerrit

Quick fix for this. Let me know if this should address the issues (seems to ...

7 years, 3 months ago (2013-09-07 00:09:06 UTC) #1

craigdh

lgtm w/ nit. Thanks! https://codereview.chromium.org/23936004/diff/1/build/android/gyp/push_libraries.py File build/android/gyp/push_libraries.py (right): https://codereview.chromium.org/23936004/diff/1/build/android/gyp/push_libraries.py#newcode17 build/android/gyp/push_libraries.py:17: sys.path.append(BUILD_ANDROID_DIR) '..' -> os.pardir

7 years, 3 months ago (2013-09-07 00:22:56 UTC) #2

craigdh

I prefer the former approach that authoritatively calls constants.SetBuildType(). The goal is to remove all ...

7 years, 3 months ago (2013-09-09 17:19:29 UTC) #4

David Trainor- moved to gerrit

On 2013/09/09 17:19:29, craigdh wrote: > I prefer the former approach that authoritatively calls > ...

7 years, 3 months ago (2013-09-09 17:25:35 UTC) #5

David Trainor- moved to gerrit

https://codereview.chromium.org/23936004/diff/1/build/android/gyp/push_libraries.py File build/android/gyp/push_libraries.py (right): https://codereview.chromium.org/23936004/diff/1/build/android/gyp/push_libraries.py#newcode17 build/android/gyp/push_libraries.py:17: sys.path.append(BUILD_ANDROID_DIR) On 2013/09/07 00:22:57, craigdh wrote: > '..' -> ...

7 years, 3 months ago (2013-09-09 17:29:17 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/23936004/16001

7 years, 3 months ago (2013-09-09 22:09:49 UTC) #7

Message was sent while issue was closed.

Change committed as 222171

Expand Messages | Collapse Messages