Add tests for imports in iframe

Add tests for imports in iframe

BUG=240592
R=dominicc,dglazkov

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157793

[Hajime Morrita, 2013-09-10 08:19:18]

Rubberstamp please and cq?
This is just adding a couple of test.

[dominicc (has gone to gerrit), 2013-09-10 23:08:55]

Comments inline.

https://codereview.chromium.org/23933004/diff/1/LayoutTests/fast/html/imports...
File LayoutTests/fast/html/imports/import-in-iframe-dynamic.html (right):

https://codereview.chromium.org/23933004/diff/1/LayoutTests/fast/html/imports...
LayoutTests/fast/html/imports/import-in-iframe-dynamic.html:7: var iframe =
document.createElement("iframe");
I think it is better to use single quotes in script and double quotes for
attributes, most things (innerHTML, script in attributes) are neater that way.

https://codereview.chromium.org/23933004/diff/1/LayoutTests/fast/html/imports...
File LayoutTests/fast/html/imports/import-in-iframe.html (right):

https://codereview.chromium.org/23933004/diff/1/LayoutTests/fast/html/imports...
LayoutTests/fast/html/imports/import-in-iframe.html:9: </body>
Clean up... Close body, script outside body, redundant close body.

[Hajime Morrita, 2013-09-11 04:32:50]

Thanks for reviewing Dominic. I updated the CL.

https://codereview.chromium.org/23933004/diff/1/LayoutTests/fast/html/imports...
File LayoutTests/fast/html/imports/import-in-iframe-dynamic.html (right):

https://codereview.chromium.org/23933004/diff/1/LayoutTests/fast/html/imports...
LayoutTests/fast/html/imports/import-in-iframe-dynamic.html:7: var iframe =
document.createElement("iframe");
On 2013/09/10 23:08:55, dominicc wrote:
> I think it is better to use single quotes in script and double quotes for
> attributes, most things (innerHTML, script in attributes) are neater that way.

Done.

https://codereview.chromium.org/23933004/diff/1/LayoutTests/fast/html/imports...
File LayoutTests/fast/html/imports/import-in-iframe.html (right):

https://codereview.chromium.org/23933004/diff/1/LayoutTests/fast/html/imports...
LayoutTests/fast/html/imports/import-in-iframe.html:9: </body>
On 2013/09/10 23:08:55, dominicc wrote:
> Clean up... Close body, script outside body, redundant close body.

Done.

[Hajime Morrita, 2013-09-11 07:01:57]

ping?

[dominicc (has gone to gerrit), 2013-09-13 01:33:03]

How about an onerror test too?

https://codereview.chromium.org/23933004/diff/8001/LayoutTests/fast/html/impo...
File LayoutTests/fast/html/imports/import-in-iframe-dynamic.html (right):

https://codereview.chromium.org/23933004/diff/8001/LayoutTests/fast/html/impo...
LayoutTests/fast/html/imports/import-in-iframe-dynamic.html:8: iframe.src
="resources/child-frame-with-import.html";
Line 7 uses ', this uses ", be consistent.

https://codereview.chromium.org/23933004/diff/8001/LayoutTests/fast/html/impo...
File LayoutTests/fast/html/imports/resources/child-frame-with-import.html
(right):

https://codereview.chromium.org/23933004/diff/8001/LayoutTests/fast/html/impo...
LayoutTests/fast/html/imports/resources/child-frame-with-import.html:7:
window.parent.titleText = target.import.querySelector('h1').innerHTML;
Heading text? This is a H1, not TITLE.

https://codereview.chromium.org/23933004/diff/8001/LayoutTests/fast/html/impo...
LayoutTests/fast/html/imports/resources/child-frame-with-import.html:8:
window.parent.shouldBe("titleText", "'Hello'");
Again, doesn't this needlessly switch from ' to "?

https://codereview.chromium.org/23933004/diff/8001/LayoutTests/fast/html/impo...
LayoutTests/fast/html/imports/resources/child-frame-with-import.html:12: <link
id="target", rel="import" href="hello.html" onload="importLoaded()">
Delete comma in the attribute list.

[Hajime Morrita, 2013-09-13 03:06:34]

Added onerror test.

https://codereview.chromium.org/23933004/diff/8001/LayoutTests/fast/html/impo...
File LayoutTests/fast/html/imports/import-in-iframe-dynamic.html (right):

https://codereview.chromium.org/23933004/diff/8001/LayoutTests/fast/html/impo...
LayoutTests/fast/html/imports/import-in-iframe-dynamic.html:8: iframe.src
="resources/child-frame-with-import.html";
On 2013/09/13 01:33:03, dominicc wrote:
> Line 7 uses ', this uses ", be consistent.

Done.

https://codereview.chromium.org/23933004/diff/8001/LayoutTests/fast/html/impo...
File LayoutTests/fast/html/imports/resources/child-frame-with-import.html
(right):

https://codereview.chromium.org/23933004/diff/8001/LayoutTests/fast/html/impo...
LayoutTests/fast/html/imports/resources/child-frame-with-import.html:7:
window.parent.titleText = target.import.querySelector('h1').innerHTML;
On 2013/09/13 01:33:03, dominicc wrote:
> Heading text? This is a H1, not TITLE.

Done.

https://codereview.chromium.org/23933004/diff/8001/LayoutTests/fast/html/impo...
LayoutTests/fast/html/imports/resources/child-frame-with-import.html:8:
window.parent.shouldBe("titleText", "'Hello'");
On 2013/09/13 01:33:03, dominicc wrote:
> Again, doesn't this needlessly switch from ' to "?

Done.

https://codereview.chromium.org/23933004/diff/8001/LayoutTests/fast/html/impo...
LayoutTests/fast/html/imports/resources/child-frame-with-import.html:12: <link
id="target", rel="import" href="hello.html" onload="importLoaded()">
On 2013/09/13 01:33:03, dominicc wrote:
> Delete comma in the attribute list.

Done.

[dominicc (has gone to gerrit), 2013-09-13 22:09:30]

LGTM

[Hajime Morrita, 2013-09-14 00:16:10]

Thanks!

[commit-bot: I haz the power, 2013-09-14 00:16:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/morrita@chromium.org/23933004/19001

[commit-bot: I haz the power, 2013-09-14 01:33:02]

Change committed as 157793

[abarth-chromium, 2013-09-16 21:13:32]

import-in-iframe-dynamic.html is very flaky:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40...

I'm going to revert that part of this CL.

[abarth-chromium, 2013-09-16 21:15:46]

Partial revert in https://codereview.chromium.org/24126006