Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: blimp/client/core/contents/android/ime_helper_dialog.h

Issue 2393043004: Blimp: IME should submit form with text (Closed)
Patch Set: dtrainor@ comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/core/contents/BUILD.gn ('k') | blimp/client/core/contents/android/ime_helper_dialog.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/core/contents/android/ime_helper_dialog.h
diff --git a/blimp/client/core/contents/android/ime_helper_dialog.h b/blimp/client/core/contents/android/ime_helper_dialog.h
index 497c65b3c6b1a796f8f15c581680d864f309ed68..d66580680e48249ceedba1f591b879d9a5258fd0 100644
--- a/blimp/client/core/contents/android/ime_helper_dialog.h
+++ b/blimp/client/core/contents/android/ime_helper_dialog.h
@@ -29,22 +29,21 @@ class ImeHelperDialog : public ImeFeature::Delegate {
~ImeHelperDialog() override;
// ImeFeature::Delegate implementation.
- void OnShowImeRequested(ui::TextInputType input_type,
- const std::string& text,
- const ImeFeature::ShowImeCallback& callback) override;
+ void OnShowImeRequested(const ImeFeature::WebInputRequest& request) override;
void OnHideImeRequested() override;
// Sends the text entered from IME to the blimp engine.
void OnImeTextEntered(JNIEnv* env,
const base::android::JavaParamRef<jobject>& jobj,
- const base::android::JavaParamRef<jstring>& text);
+ const base::android::JavaParamRef<jstring>& text,
+ jboolean submit);
private:
base::android::ScopedJavaGlobalRef<jobject> java_obj_;
- // A callback for the current request to be executed on text submission from
- // the user.
- ImeFeature::ShowImeCallback text_submit_callback_;
+ // The current request is saved in order to populate the fields of the
+ // subsequent response.
+ ImeFeature::WebInputRequest current_request_;
DISALLOW_COPY_AND_ASSIGN(ImeHelperDialog);
};
« no previous file with comments | « blimp/client/core/contents/BUILD.gn ('k') | blimp/client/core/contents/android/ime_helper_dialog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698