[rAc] Reset the user's selection to the new default when the default Wallet item changes.

[rAc] Reset the user's selection to the new default when the default Wallet item changes.

When the user opts to "Manage billing details" and changes the default payment
instrument (credit card) or shipping address, select the new default in the
requestAutocomplete dialog UI.

BUG=266010
TEST=unit_tests
R=estade@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221655

[Evan Stade, 2013-09-04 19:25:28]

lgtm

https://codereview.chromium.org/23930002/diff/1/chrome/browser/ui/autofill/au...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right):

https://codereview.chromium.org/23930002/diff/1/chrome/browser/ui/autofill/au...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:2417:
previously_selected_instrument_id_.clear();
can you keep all this default instrument logic in one place? i.e. move the
default_instrument_id logic up here

(same for the default shipping id stuff)

https://codereview.chromium.org/23930002/diff/1/chrome/browser/ui/autofill/au...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:2454:
previously_selected_instrument_id_.clear();
do we still need this here?

https://codereview.chromium.org/23930002/diff/1/chrome/browser/ui/autofill/au...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.h (right):

https://codereview.chromium.org/23930002/diff/1/chrome/browser/ui/autofill/au...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.h:573: // The default
active instrument and shipping address object ids as of the
nit: s/ids/IDs/

[Ilya Sherman, 2013-09-05 01:13:55]

https://codereview.chromium.org/23930002/diff/1/chrome/browser/ui/autofill/au...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right):

https://codereview.chromium.org/23930002/diff/1/chrome/browser/ui/autofill/au...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:2417:
previously_selected_instrument_id_.clear();
On 2013/09/04 19:25:28, Evan Stade wrote:
> can you keep all this default instrument logic in one place? i.e. move the
> default_instrument_id logic up here
> 
> (same for the default shipping id stuff)

Done.

https://codereview.chromium.org/23930002/diff/1/chrome/browser/ui/autofill/au...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:2454:
previously_selected_instrument_id_.clear();
On 2013/09/04 19:25:28, Evan Stade wrote:
> do we still need this here?

Done.

https://codereview.chromium.org/23930002/diff/1/chrome/browser/ui/autofill/au...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.h (right):

https://codereview.chromium.org/23930002/diff/1/chrome/browser/ui/autofill/au...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.h:573: // The default
active instrument and shipping address object ids as of the
On 2013/09/04 19:25:28, Evan Stade wrote:
> nit: s/ids/IDs/

Done.

[commit-bot: I haz the power, 2013-09-05 01:14:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/23930002/6001

[commit-bot: I haz the power, 2013-09-05 02:18:15]

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-09-05 03:22:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/23930002/6001

[commit-bot: I haz the power, 2013-09-05 03:52:29]

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-09-05 03:54:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/23930002/6001

[commit-bot: I haz the power, 2013-09-05 04:21:43]

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-09-06 03:11:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/23930002/6001

[commit-bot: I haz the power, 2013-09-06 08:58:10]

Change committed as 221655