Issue 23927010: No need to forward declare GeolocationProviderTest in geolocation_provider_impl.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23927010: No need to forward declare GeolocationProviderTest in geolocation_provider_impl.h. (Closed)

Created:
7 years, 3 months ago by Michael van Ouwerkerk

Modified:
7 years, 3 months ago

Reviewers:
bulach

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Michael van Ouwerkerk

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

No need to forward declare GeolocationProviderTest in geolocation_provider_impl.h. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222078

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	content/browser/geolocation/geolocation_provider_impl.h	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/23927010/1

7 years, 3 months ago (2013-09-09 12:40:54 UTC) #3

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=76738

7 years, 3 months ago (2013-09-09 15:20:26 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/23927010/1

7 years, 3 months ago (2013-09-09 19:17:32 UTC) #5

Message was sent while issue was closed.

Change committed as 222078

Expand Messages | Collapse Messages