Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: chrome/browser/bookmarks/DEPS

Issue 23927008: bookmarks: Add chrome/test/base entries to the exception list. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 include_rules = [ 1 include_rules = [
2 # Bookmarks is being made into a component (it will end up at 2 # Bookmarks is being made into a component (it will end up at
3 # //components/bookmarks and not depend on //chrome), so we have these basic 3 # //components/bookmarks and not depend on //chrome), so we have these basic
4 # rules followed by temporary exceptions. Please don't add to the list of 4 # rules followed by temporary exceptions. Please don't add to the list of
5 # exceptions! 5 # exceptions!
6 "-chrome/browser", 6 "-chrome/browser",
7 "+chrome/browser/bookmarks", 7 "+chrome/browser/bookmarks",
8 "+chrome/browser/favicon", 8 "+chrome/browser/favicon",
9 "+chrome/browser/chrome_notification_types.h", 9 "+chrome/browser/chrome_notification_types.h",
10 10
11 # TODO(tfarina): Bring this list to zero. crbug.com/144783 11 # TODO(tfarina): Bring this list to zero. crbug.com/144783
12 # Do not add to the list of temporarily-allowed dependencies below, 12 # Do not add to the list of temporarily-allowed dependencies below,
13 # and please do not introduce more #includes of these files. 13 # and please do not introduce more #includes of these files.
14 "!chrome/browser/history/history_service.h", 14 "!chrome/browser/history/history_service.h",
15 "!chrome/browser/history/history_service_factory.h", 15 "!chrome/browser/history/history_service_factory.h",
16 "!chrome/browser/history/query_parser.h", 16 "!chrome/browser/history/query_parser.h",
17 "!chrome/browser/history/url_database.h", 17 "!chrome/browser/history/url_database.h",
18 "!chrome/browser/profiles/incognito_helpers.h", 18 "!chrome/browser/profiles/incognito_helpers.h",
19 "!chrome/browser/profiles/profile.h", 19 "!chrome/browser/profiles/profile.h",
20 "!chrome/browser/profiles/startup_task_runner_service.h", 20 "!chrome/browser/profiles/startup_task_runner_service.h",
21 "!chrome/browser/profiles/startup_task_runner_service_factory.h", 21 "!chrome/browser/profiles/startup_task_runner_service_factory.h",
22 # Do not add to the list of temporarily-allowed dependencies above, 22 # Do not add to the list of temporarily-allowed dependencies above,
23 # and please do not introduce more #includes of these files. 23 # and please do not introduce more #includes of these files.
24 ] 24 ]
25 25
26 specific_include_rules = { 26 specific_include_rules = {
27 # For unit tests, it's fine to include utility process code. 27 # For unit tests, it's fine to include utility process code.
28 '.*test\.cc': [ 28 '.*test\.cc': [
29 "!chrome/test/base/testing_profile.h",
30 "!chrome/test/base/ui_test_utils.h",
29 "+chrome/utility/importer/bookmark_html_reader.h", 31 "+chrome/utility/importer/bookmark_html_reader.h",
30 ], 32 ],
31 } 33 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698