Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23927006: Added numeric layout to VK. (Closed)

Created:
7 years, 3 months ago by rsadam
Modified:
7 years, 3 months ago
Reviewers:
sadrul, bshe
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Added a numeric layout to Virtual Keyboard. First step for addressing the bug below. BUG=284513 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221305

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed indents. #

Patch Set 3 : Fixed indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M ui/keyboard/keyboard_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/keyboard_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/resources/index.html View 1 chunk +1 line, -0 lines 0 comments Download
A ui/keyboard/resources/layouts/numeric.html View 1 2 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
rsadam
7 years, 3 months ago (2013-09-04 17:47:09 UTC) #1
bshe
lgtm with nit https://codereview.chromium.org/23927006/diff/1/ui/keyboard/resources/layouts/numeric.html File ui/keyboard/resources/layouts/numeric.html (right): https://codereview.chromium.org/23927006/diff/1/ui/keyboard/resources/layouts/numeric.html#newcode11 ui/keyboard/resources/layouts/numeric.html:11: <template> nit: indent seems off here.
7 years, 3 months ago (2013-09-04 18:05:19 UTC) #2
rsadam
For some reason it was a tab rather than spaces. Fixed! https://codereview.chromium.org/23927006/diff/1/ui/keyboard/resources/layouts/numeric.html File ui/keyboard/resources/layouts/numeric.html (right): ...
7 years, 3 months ago (2013-09-04 18:09:38 UTC) #3
rsadam
On 2013/09/04 18:09:38, rsadam wrote: > For some reason it was a tab rather than ...
7 years, 3 months ago (2013-09-04 18:21:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/23927006/13001
7 years, 3 months ago (2013-09-04 18:22:32 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=23725
7 years, 3 months ago (2013-09-04 18:33:44 UTC) #6
rsadam
Added sadrul as a reviewer
7 years, 3 months ago (2013-09-04 18:44:33 UTC) #7
sadrul
lgtm
7 years, 3 months ago (2013-09-04 18:46:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/23927006/13001
7 years, 3 months ago (2013-09-04 18:49:59 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 23:54:16 UTC) #10
Message was sent while issue was closed. 
Change committed as 221305

Powered by Google App Engine
This is Rietveld 408576698