Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 23926014: Files.app: Added the nameText field to TestEntryInfo class. (Closed)

Created:
7 years, 3 months ago by hirono
Modified:
7 years, 3 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rginda+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Files.app: Added the nameText field to TestEntryInfo class. Originally, we assume the target name of entry provided to FakeFileSystem and expected name actually shown in the file list is the same. But for hosted documents on the drive, both name can be different. To handle the case, this CL adds the nameText field to TestEntryInfo class. BUG=279774 TEST=file_manager_browsertests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223556

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js View 3 chunks +16 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hirono
Could you take a look the CL? Thank you!
7 years, 3 months ago (2013-09-13 02:57:07 UTC) #1
yoshiki
lgtm
7 years, 3 months ago (2013-09-17 04:04:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/23926014/1
7 years, 3 months ago (2013-09-17 04:14:18 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 06:57:34 UTC) #4
Message was sent while issue was closed.
Change committed as 223556

Powered by Google App Engine
This is Rietveld 408576698