Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2392433002: Avoid showing two dots in ellipsis (Closed)

Created:
4 years, 2 months ago by rhogan
Modified:
4 years, 2 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid showing two dots in ellipsis The progression is seen in fast/text/ellipsis-at-edge-of-rtl-text-in-ltr-flow.html and fast/css/text-overflow-input.html. We also now show an exta character of text before the ellipsis where space is available. BUG=650083 Committed: https://crrev.com/97e3ea432760b509a811e130aa728a21f0fe2fc1 Cr-Commit-Position: refs/heads/master@{#426997}

Patch Set 1 #

Patch Set 2 : bug 650083 #

Patch Set 3 : bug 650083 #

Patch Set 4 : bug 650083 #

Patch Set 5 : bug 650083 #

Patch Set 6 : bug 650083 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -71 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 1 chunk +30 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/text-overflow-ellipsis-button.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/text-overflow-ellipsis-button-expected.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/editing/composition-marker-split-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-bidi-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-strict-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-text-align-center-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-text-align-center-expected.txt View 1 2 3 2 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-text-align-justify-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-text-align-left-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-text-align-left-expected.txt View 1 2 3 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-text-align-right-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-text-align-right-expected.txt View 1 2 3 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-input-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt View 1 2 3 2 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt View 1 2 3 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/overflow/line-clamp-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-at-edge-of-rtl-text-in-ltr-flow-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-ltr-text-in-ltr-flow-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-ltr-text-in-ltr-flow-underline-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-ltr-text-in-rtl-flow-underline-composition-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-platform-font-change-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-ltr-flow-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-ltr-flow-underline-composition-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-ltr-flow-underline-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 30 (25 generated)
rhogan
4 years, 2 months ago (2016-10-19 10:16:40 UTC) #23
eae
LGTM w/nit Would you mind adding a comment explaining what the bool does and why ...
4 years, 2 months ago (2016-10-19 15:19:57 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392433002/100001
4 years, 2 months ago (2016-10-23 10:04:52 UTC) #27
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 2 months ago (2016-10-23 13:42:49 UTC) #28
commit-bot: I haz the power
4 years, 2 months ago (2016-10-23 13:49:58 UTC) #30
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/97e3ea432760b509a811e130aa728a21f0fe2fc1
Cr-Commit-Position: refs/heads/master@{#426997}

Powered by Google App Engine
This is Rietveld 408576698