Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1315)

Issue 23922007: Merge the LinuxUI interface from its own .so into libviews.so. (Closed)

Created:
7 years, 3 months ago by Elliot Glaysher
Modified:
7 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka, sadrul, tfarina, ben+watch_chromium.org
Visibility:
Public.

Description

Merge the LinuxUI interface from its own .so into libviews.so. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -306 lines) Patch
M chrome/browser/download/download_status_updater.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/themes/theme_service_aurax11.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/themes/theme_service_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/app_indicator_icon.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/libgtk2ui.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/status_icons/status_icon_linux_wrapper.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_icon_linux_wrapper.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_tray_linux.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D ui/linux_ui/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D ui/linux_ui/linux_ui.h View 1 chunk +0 lines, -77 lines 0 comments Download
D ui/linux_ui/linux_ui.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D ui/linux_ui/linux_ui.gyp View 1 chunk +0 lines, -33 lines 0 comments Download
D ui/linux_ui/linux_ui_export.h View 1 chunk +0 lines, -36 lines 0 comments Download
D ui/linux_ui/status_icon_linux.h View 1 chunk +0 lines, -58 lines 0 comments Download
D ui/linux_ui/status_icon_linux.cc View 1 chunk +0 lines, -17 lines 0 comments Download
A + ui/views/linux_ui/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/linux_ui/linux_ui.h View 5 chunks +11 lines, -11 lines 0 comments Download
A + ui/views/linux_ui/linux_ui.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/views/linux_ui/linux_ui.gyp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/linux_ui/status_icon_linux.h View 3 chunks +8 lines, -4 lines 0 comments Download
A + ui/views/linux_ui/status_icon_linux.cc View 2 chunks +5 lines, -1 line 0 comments Download
M ui/views/views.gyp View 2 chunks +9 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Elliot Glaysher
This does the cleanup I talked about last week when you suggested someone move something ...
7 years, 3 months ago (2013-09-09 22:46:52 UTC) #1
Elliot Glaysher
This does the cleanup I talked about last week when you suggested someone move something ...
7 years, 3 months ago (2013-09-09 22:46:53 UTC) #2
sky
LGTM
7 years, 3 months ago (2013-09-09 23:33:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/23922007/1
7 years, 3 months ago (2013-09-09 23:34:00 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 09:22:26 UTC) #5
Message was sent while issue was closed.
Change committed as 222239

Powered by Google App Engine
This is Rietveld 408576698