Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2390603002: Make SdchOwner a client of memory coordinator (Closed)

Created:
4 years, 2 months ago by hajimehoshi
Modified:
4 years, 2 months ago
Reviewers:
chrisha, Ryan Sleevi, bashi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make SdchOwner a client of memory coordinator When the memory coordinator is enabled, SdchOwner becomes a client of the memory coordinator instead of installing MemoryPressureListener. In the implmentation of this CL, both MemoryPressureListener and MemoryCoordinatorClient are installed regardless of the flag, but as default MemoryCoordinator is not enabled and when MemoryCoordinator is enabled by a flag, it is planed to suppress MemoryPressureMonitor features. Design Doc: https://docs.google.com/document/d/1a69mMr7jI7qK0OfKNlrZ350xiXizVMCCe8orGX7K8Uo/edit?ts=57d7968b# BUG=639700 Committed: https://crrev.com/651a10b49a97e21f805aca384d734f3879cd66db Cr-Commit-Position: refs/heads/master@{#422698}

Patch Set 1 #

Patch Set 2 : Fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M net/sdch/sdch_owner.h View 3 chunks +9 lines, -1 line 0 comments Download
M net/sdch/sdch_owner.cc View 1 4 chunks +24 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
hajimehoshi
PTAL
4 years, 2 months ago (2016-10-03 07:31:41 UTC) #2
Ryan Sleevi
lgtm
4 years, 2 months ago (2016-10-03 23:12:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390603002/20001
4 years, 2 months ago (2016-10-04 03:50:17 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 03:55:38 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 03:59:37 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/651a10b49a97e21f805aca384d734f3879cd66db
Cr-Commit-Position: refs/heads/master@{#422698}

Powered by Google App Engine
This is Rietveld 408576698